Repository navigation
Add regression tests for EEGLAB issues 933, 941, 946 and 953 - #15
Open
arnodelorme wants to merge 1 commit into
Open
arnodelorme wants to merge 1 commit into
arnodelorme wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four function-based tests covering the fixes proposed in sccn/eeglab PRs 958 (pop_subcomp history keeps the retain flag), 960 (eegplot shades event durations spanning the window, both implementations), 961 (pop_chanedit with and without DIPFIT) and 963 (binary data read as single when the option is on). The precision test toggles the single-precision option through pop_editoptions and restores the user's option file afterwards. All nine tests pass locally against a checkout containing the six fixes (MATLAB R2025b). They will fail in CI until those PRs are merged and the eeglab submodule pointer is updated.