Skip to content

fix(SelectInput): alignments#6516

Open
lisalupi wants to merge 4 commits into
mainfrom
fix/select-input-border
Open

fix(SelectInput): alignments#6516
lisalupi wants to merge 4 commits into
mainfrom
fix/select-input-border

Conversation

@lisalupi

@lisalupi lisalupi commented Jun 5, 2026

Copy link
Copy Markdown
Collaborator

Summary

Type

  • Bug

Summarize concisely:

What is expected?

SelectInput:
- add a transparent border when disabled to avoid sizing differences between read-only, default, and disabled states
- fix options alignment with checkbox and OptionalInfo

Before (no border when disabled):

Enregistrement.de.l.ecran.2026-06-08.a.10.07.55.mov

After (border when disabled):

Enregistrement.de.l.ecran.2026-06-08.a.10.07.29.mov

@lisalupi lisalupi requested review from a team and mhervouet June 5, 2026 12:42
@lisalupi lisalupi self-assigned this Jun 5, 2026
@lisalupi lisalupi requested a review from jsulpis as a code owner June 5, 2026 12:42
@lisalupi lisalupi requested review from JulienSaguez and jsulpis and removed request for a team June 5, 2026 12:42
@lisalupi lisalupi added the bug Something isn't working label Jun 5, 2026
@changeset-bot

changeset-bot Bot commented Jun 5, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: f0a340e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ultraviolet/ui Patch
@ultraviolet/form Patch
@ultraviolet/nextjs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov

codecov Bot commented Jun 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.06%. Comparing base (48a44bb) to head (f0a340e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6516      +/-   ##
==========================================
+ Coverage   82.37%   92.06%   +9.69%     
==========================================
  Files          44      536     +492     
  Lines         658     9607    +8949     
  Branches      185     3553    +3368     
==========================================
+ Hits          542     8845    +8303     
- Misses        116      762     +646     
Files with missing lines Coverage Δ
...nents/SelectInput/components/Dropdown/Dropdown.tsx 87.85% <100.00%> (ø)
...ponents/SelectInput/components/Dropdown/Option.tsx 100.00% <100.00%> (ø)
...ts/SelectInput/components/Dropdown/dropdown.css.ts 100.00% <100.00%> (ø)
.../SelectInput/components/SelectBar/selectBar.css.ts 100.00% <ø> (ø)
packages/ui/src/components/SelectInput/index.tsx 100.00% <ø> (ø)
...ckages/ui/src/components/SelectInput/styles.css.ts 100.00% <ø> (ø)

... and 486 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9fb228...f0a340e. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jsulpis jsulpis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the alignment is fixed for the "left" placement but not for the "right" : the elements are pushed at the top and not vertically aligned

Image Image

@lisalupi

lisalupi commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator Author

the alignment is fixed for the "left" placement but not for the "right" : the elements are pushed at the top and not vertically aligned
Image Image

I was told to align with the top, not center

Comment thread packages/ui/src/components/SelectInput/components/SelectBar/selectBar.css.ts Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants