Upgrade dependencies to latest and fix resulting breakages#210
Merged
Conversation
Bump all dependencies to latest, including major upgrades: TypeScript 6, @github/copilot-sdk 1.0, lucide-react 1.x, electron 42, vite-plugin-static-copy 4, lint-staged 17. Adapt to breaking changes: - TS6: remove deprecated baseUrl (use ./src/* path), add *.css ambient module declaration, drop now-unnecessary type assertions flagged by typescript-eslint. - copilot-sdk 1.0: handler is now optional on Tool (guard in registerTools); ToolBinaryResult.type narrowed to 'image' | 'resource'; exit_plan_mode selectedAction enum changed (map exit_only/autopilot_fleet); use 'satisfies Tool' for submitDocumentPlanTool and align its test to the 1-arg handler. - Keep vscode-jsonrpc at ^8.2.1: v9 drops the /node.js subpath that @github/copilot-sdk (requires ^8.2.1) imports. All 537 unit + 545 integration tests pass; typecheck, lint, and build are clean. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Two upgrade-related breakages surfaced in the Playwright UI suite:
1. SDK 1.0 no longer auto-discovers marketplace-installed CLI plugins for SDK-created sessions, so the host-default agent (office-excel:excel, etc.) failed session.create with 'Custom agent not found'. The proxy now resolves the installed Office plugin directories and passes them as createSession({ pluginDirectories }), which re-loads the plugin-owned agents. Added getInstalledOfficePluginDirectories() helper (honors COPILOT_HOME) plus its .d.mts types and integration tests.
2. The @github/copilot CLI bump dropped the old model ids the UI fixtures hardcoded (claude-sonnet-4, gpt-4.1, gemini-2.5-pro). Updated tests-ui/fixtures.ts and settings-dialog.spec.ts to current ids (claude-sonnet-4.6, gpt-5.4, gemini-3.1-pro-preview).
All 44 UI, 545 integration, and 537 unit tests pass.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
SDK >=1.0 only loads plugin-owned agents from explicit pluginDirectories. When an agent is requested but no Office plugin directories were resolved, createSession fails with a cryptic 'Custom agent not found'. Surface the real cause with an upfront proxy warning pointing at the startup bootstrap and COPILOT_HOME. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades all dependencies to their latest versions and fixes the breakages introduced by the major bumps (TypeScript 6,
@github/copilot-sdk1.0, etc.), then repairs the Playwright UI suite.Changes
Dependency upgrade (8f4b42c)
vscode-jsonrpcat^8.2.1- v9 drops the./node.jsexports subpath that@github/copilot-sdk(requires^8.2.1) imports.baseUrl(path mapping to./src/*); addedsrc/types/css.d.tsambient module for CSS side-effect imports; removed now-unnecessary type assertions.Tool.handlernow optional (guarded in registerTools);ToolBinaryResult.typenarrowed to'image' | 'resource'; remapped the changedexit_plan_modeselectedActionenum;satisfies Toolon the Word planner tool.UI test fixes (e043d79)
tests-ui/fixtures.ts(e.g.claude-sonnet-4toclaude-sonnet-4.6,gpt-4.1togpt-5.4).copilot-climode. AddedgetInstalledOfficePluginDirectories()and wiredpluginDirectoriesinto the proxy'screateSessionso agents likeoffice-excel:excelresolve again.Proxy warning (23b931d)
Testing
npm run test:e2e*) require real Office Desktop hosts - not run in this environment.