Repository navigation
ai: recover CLI report envelopes with literal control characters - #906
Merged
Merged
Conversation
CLI providers request a JSON content envelope even when a report stage needs plain text. Models can leave literal tabs or newlines inside that string. Strict parsing then returns the raw wrapper, making an otherwise usable report fail plain-text validation. Reuse the existing control-character normalizer only for an otherwise invalid, single-field string content object. Preserve the decoded report exactly and leave malformed tool calls and structural errors on their existing paths. Clarify the envelope instructions and log expected raw-text fallback at debug level. Include the design and regression coverage for fenced report recovery, preserved inner fences, and rejection of malformed envelopes and arrays. Fixes: 9cccc05 ("feat: add claude-cli provider for Claude Code subscription auth") Signed-off-by: Andrea Righi <arighi@nvidia.com>
Sashiko review✓ No issues found across 1 commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLI providers request a JSON content envelope even when a report stage needs plain text. Models can leave literal tabs or newlines inside that string. Strict parsing then returns the raw wrapper, making an otherwise usable report fail plain-text validation.
Reuse the existing control-character normalizer only for an otherwise invalid, single-field string content object. Preserve the decoded report exactly and leave malformed tool calls and structural errors on their existing paths. Clarify the envelope instructions and log expected raw-text fallback at debug level.
Include the design and regression coverage for fenced report recovery, preserved inner fences, and rejection of malformed envelopes and arrays.
Fixes: 9cccc05 ("feat: add claude-cli provider for Claude Code subscription auth")