fix: create missing sap_sa38_run.vbs to unblock CI validate job - #6
Merged
Conversation
…CI failure
Root cause: check-consistency.mjs gate was failing with HARD ERROR because
skills/sap-run-report/SKILL.md:35 referenced references/sap_sa38_run.vbs
which did not exist on disk (exit code 1).
Changes:
1. Create plugins/sap-dev-core/skills/sap-run-report/references/sap_sa38_run.vbs
- SA38 driver for FG (F8 execute + best-effort %PC list capture) and BG
(Execute in Background via SAPLSPRI/SAPLBTCH popups) modes
- Follows the sap_sa38_variant.vbs pattern: session attach via AttachSapSession,
FillValues/SetField/FillMultiSelect helpers, LoadVariant via Shift+F5
- Emits RUN_REPORT: EXECUTED_FG / SUBMITTED / NEEDS_RECORDING / ERROR lines
- sap_sa38_run.screens.json was already committed; new VBS picked up by
screen-baseline coverage (now 126/127 driving VBS with baselines)
2. Add .gitignore exception for the new source VBS
- The existing sap_*_run.vbs rule (for runtime-generated temp copies like
sap_sa38_run_run.vbs) also matched the source reference file
- Added !plugins/sap-dev-core/skills/sap-run-report/references/sap_sa38_run.vbs
following the precedent of sap_probe_end_of_run.ps1
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job validate
fix: create missing sap_sa38_run.vbs to unblock CI validate job
Jul 9, 2026
KexiHe
approved these changes
Jul 9, 2026
KexiHe
approved these changes
Jul 9, 2026
KexiHe
marked this pull request as ready for review
July 9, 2026 10:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
validateCI job was hard-failing becausecheck-consistency.mjsdetected thatskills/sap-run-report/SKILL.md:35referencedreferences/sap_sa38_run.vbswhich was never committed — the screens JSON and variant VBS for the same skill were already present, but the run driver was missing.Changes
references/sap_sa38_run.vbs— new SA38 report execution driver:Shift+F5variant load → optional--valuesfill → F8 execute → best-effort%PCclassic-list capture to--save-output. EmitsRUN_REPORT: EXECUTED_FG list_saved=<path|NONE> sbar=<type>.menu[0]/menu[2](Execute in Background) → handles SAPLSPRI print-params (btn[13]) and SAPLBTCH start-time (btnSOFORT_PUSH+btn[11]) popups. EmitsRUN_REPORT: SUBMITTED job=<name> count=<n>.RUN_REPORT: NEEDS_RECORDINGon any unresolved screen/control — never claims a false success.sap_sa38_variant.vbspatterns:AttachSapSession,FillValues/SetField/FillMultiSelect,LoadVariantvia SAPLSVAR Find popup..gitignore— added negation exception!plugins/sap-dev-core/skills/sap-run-report/references/sap_sa38_run.vbs. The existingsap_*_run.vbsexclusion (targeting runtime-generated temp copies likesap_sa38_run_run.vbs) was also matching this committed source file. Follows the same pattern as the existing!.../sap_probe_end_of_run.ps1exception.