fix(tls): prevent crash when altNames in cert are not strings#26
Open
NikosRig wants to merge 1 commit into
Open
fix(tls): prevent crash when altNames in cert are not strings#26NikosRig wants to merge 1 commit into
NikosRig wants to merge 1 commit into
Conversation
Guarded against non-string values in `isMappingHostName()` by extracting `.value` and validating type before using `.replace()`. Also updated `getMappingHostNamesFormCert()` to safely extract altNames. Fixes `TypeError: DNSName.replace is not a function` caused by altNames being objects instead of strings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🐛 Fix: TypeError in isMappingHostName for non-string DNS names
Description
This PR resolves a runtime error that occurs when the subjectAltName entries in a TLS certificate are objects instead of plain strings. The isMappingHostName() function was calling .replace() on these objects, leading to the following error:
TypeError: DNSName.replace is not a function
Changes
Added type checking in isMappingHostName() to extract .value safely and ensure it's a string before calling .replace().
Improved getMappingHostNamesFormCert() to filter and include only valid string values from altNames.
Why it matters
Without this fix, certain certificates cause the proxy to crash when intercepting HTTPS traffic due to incorrect handling of DNSName types in certificates.
How to test
Run the proxy server with SSL MITM enabled.
Visit a site with multiple or wildcard SANs in its cert.
Confirm no crash occurs and the traffic is intercepted correctly.