Repository navigation
fix(status): page through app installations and report revalidation errors - #45
Merged
jimjag merged 2 commits intoNov 16, 2026
Merged
Conversation
…rrors The installations lookup made one request, so orgs outside the first 30 installations were never found. Revalidation then failed, and the status page showed the error as every contributor having signed the CLA.
|
Thanks for the contribution! Before we can merge this, we need @mwbrooks to sign the Salesforce Inc. Contributor License Agreement. |
mwbrooks
marked this pull request as ready for review
November 15, 2026 22:18
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes the CLA status page for orgs that are not in the first 30 installations of the GitHub App. For those orgs the page says "All external contributors have signed the CLA" on every pull request, even when the
salesforce-clacheck is failing. Signing the CLA doesn't update the pull request either.Summary
integrationInstallations()made a singleGET /app/installationsrequest. GitHub returns 30 installations per page by default, so any org after the first page was never found and revalidation failed with "GitHub App not installed on ...". It now pages through every installation using the existingLinkheader paging. That also fixes the revalidation that runs after someone signs without a pull request URL, which loops over every installation.revalidatePullRequestcaught every error and returned empty results (added in 63b692b), which the status page renders as "signed". The status page now shows an error and logs it, and the existingNeedsAuthredirect and "Repo Not Found" cases work again. The sign flow keeps catching the error, because the signature is already saved at that point.Testing
sbt compile Test/compilepasses on Java 21.0.13 and Play 2.9.6.sbt testnot run, becauseGitHubSpecneeds live GitHub App credentials./status/<org>/<repo>/pull/<n>for an org outside the first page of installations and confirm the check status and label update.Notes
slackapipull requests such as fix(scim): keep list-of-strings values flat when converting response keys slackapi/python-slack-sdk#2041, where the check fails and the status page says everyone signed. A similar report came fromforcedotcom/afv-library.