docs: point ADR-0077's recovery message at the write lease - #1671
Open
newhoggy wants to merge 1 commit into
Open
docs: point ADR-0077's recovery message at the write lease#1671newhoggy wants to merge 1 commit into
newhoggy wants to merge 1 commit into
Conversation
ADR-0080 §9 now requires --lease on every Sheets/Docs write verb, including the four SheetsDelete ones — so the "there is still no recovery path but Drive's own version history" claim ADR-0077 §5 made no longer holds: drive lease acquire already backs the file up before every destructive write. Update the runtime message (structure.rs's RECOVERY_NOTE and its DeleteSheetCommand doc comment), docs/drive.md's example output, and ADR-0080's own Status and Consequences sections (which already tracked this as a pending supersession) to say so, pointing at the Drive UI for now since drive lease restore (Phase 4) hasn't landed yet. ADR-0077 itself is left untouched, matching this codebase's existing convention of newer ADRs documenting what they change about older ones rather than editing accepted ADRs in place.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--leaseis required on every Sheets/Docs write verb (including the fourSheetsDeleteones), anddrive lease acquirealready backs the file up before the write — so ADR-0077 §5's "there is still no recovery path but Drive's own version history" no longer holds.structure.rs'sRECOVERY_NOTE, itsDeleteSheetCommanddoc comment) anddocs/drive.md's example output to point at the lease's own backup first, falling back to Drive's version history.drive lease restore(Phase 4) hasn't landed yet.Test plan
cargo test --lib— full suite (9330 passed)cargo clippy --all-targets -- -D warningscargo fmt --checkdescribe_lines/describefordelete-sheet) to match the new wording