Skip to content

docs: point ADR-0077's recovery message at the write lease - #1671

Open
newhoggy wants to merge 1 commit into
mainfrom
docs-1664-adr-0077-lease-recovery
Open

docs: point ADR-0077's recovery message at the write lease#1671
newhoggy wants to merge 1 commit into
mainfrom
docs-1664-adr-0077-lease-recovery

Conversation

@newhoggy

Copy link
Copy Markdown
Contributor

Summary

  • Since Drive write lease Phase 3 (part 2): require --lease on every Sheets/Docs write verb #1670, --lease is required on every Sheets/Docs write verb (including the four SheetsDelete ones), and drive lease acquire already backs the file up before the write — so ADR-0077 §5's "there is still no recovery path but Drive's own version history" no longer holds.
  • Updates the runtime recovery message (structure.rs's RECOVERY_NOTE, its DeleteSheetCommand doc comment) and docs/drive.md's example output to point at the lease's own backup first, falling back to Drive's version history.
  • Updates ADR-0080's Status and Consequences sections, which already tracked this as a pending supersession ("will supersede ADR-0077 §5 ... once Phase 3 below lands — not yet"), to reflect that it has now landed.
  • ADR-0077 itself is left untouched — matches this codebase's existing convention (see ADR-0075/ADR-0077) of a newer ADR documenting what it changes about an older one, rather than editing an accepted ADR in place.
  • The message still points at the Drive UI for the actual restore, since drive lease restore (Phase 4) hasn't landed yet.

Test plan

  • cargo test --lib — full suite (9330 passed)
  • cargo clippy --all-targets -- -D warnings
  • cargo fmt --check
  • Updated the one test asserting on the old message text (describe_lines/describe for delete-sheet) to match the new wording

ADR-0080 §9 now requires --lease on every Sheets/Docs write verb,
including the four SheetsDelete ones — so the "there is still no
recovery path but Drive's own version history" claim ADR-0077 §5
made no longer holds: drive lease acquire already backs the file up
before every destructive write. Update the runtime message
(structure.rs's RECOVERY_NOTE and its DeleteSheetCommand doc
comment), docs/drive.md's example output, and ADR-0080's own Status
and Consequences sections (which already tracked this as a pending
supersession) to say so, pointing at the Drive UI for now since
drive lease restore (Phase 4) hasn't landed yet.

ADR-0077 itself is left untouched, matching this codebase's existing
convention of newer ADRs documenting what they change about older
ones rather than editing accepted ADRs in place.
@github-actions

Copy link
Copy Markdown

Coverage

Total: 97.24% ⚪ 0 pp vs main

Comparing b870d4f..97076db (merge-base → PR head)

No per-file coverage changes vs main.

Patch coverage

Patch: 100% (2/2 new lines covered)

File Patch Uncovered new lines
src/drive/sheets/structure.rs 100% (2/2)

📦 Full per-file coverage summary · run summary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant