Skip to content

feat(paging): add VirtAddr57/RT support for Page - #619

Open
aarkegz wants to merge 2 commits into
rust-osdev:nextfrom
aarkegz:la57_paging
Open

feat(paging): add VirtAddr57/RT support for Page#619
aarkegz wants to merge 2 commits into
rust-osdev:nextfrom
aarkegz:la57_paging

Conversation

@aarkegz

@aarkegz aarkegz commented Oct 10, 2026

Copy link
Copy Markdown

This PR is the second part of #599, after #605.

This PR makes page and page table types like Page, Mapper, MappedPageTable, RecursivePageTable, etc, work with VirtAddr57/RT introduced in #605.

@aarkegz
feat(paging): support fixed-width and runtime addresses in Page
5dc1ef3 
Generalize Page, page ranges, arithmetic, and stepping over virtual-address
validity policies while retaining VA48 defaults. Add four- and five-level
index constructors with fixed-width and runtime regression coverage.

Provide the generic address alignment helper needed by Page, extend
PageTableLevel to P5, and accept generic virtual addresses for TLB
invalidation. Disambiguate existing VA48 page-constructor calls.
@aarkegz aarkegz mentioned this pull request Oct 10, 2026
Merged
@Freax13

Freax13 commented Oct 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Thank you for your contribution!

This PR is way too big.
screenshot of the diff stat showing 4510 added lines and 1384 removed lines
Please split this PR up into several smaller PRs.

@aarkegz

aarkegz commented Oct 11, 2026

Copy link
Copy Markdown
Author

Thank you for your contribution!

This PR is way too big. screenshot of the diff stat showing 4510 added lines and 1384 removed lines Please split this PR up into several smaller PRs.

OK. Maybe we should handle Page first and page tables later?

@Freax13

Freax13 commented Oct 11, 2026

Copy link
Copy Markdown
Member

Thank you for your contribution!
This PR is way too big. screenshot of the diff stat showing 4510 added lines and 1384 removed lines Please split this PR up into several smaller PRs.

OK. Maybe we should handle Page first and page tables later?

Yes, please. The page table related changes should likely also be split up into several PRs if possible.

@aarkegz aarkegz changed the title feat(paging): add VirtAddr57/RT support for page and page table types feat(paging): add VirtAddr57/RT support for Page Oct 11, 2026
@aarkegz

aarkegz commented Oct 11, 2026

Copy link
Copy Markdown
Author

Yes, please. The page table related changes should likely also be split up into several PRs if possible.

Hi @Freax13, I've broken this PR down into smaller pieces (about three or four), and it now contains only the updates to Page.

@aarkegz aarkegz mentioned this pull request Oct 11, 2026
Draft
1 of 2 tasks
@aarkegz

aarkegz commented Oct 11, 2026

Copy link
Copy Markdown
Author

Also, I've just noticed that a number of PRs have been merged into main recently, can we merge them back to next before or after merge this PR? As these PRs changed page and page table types also.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aarkegz @Freax13