Fix Windows CI's Powershell not propagate error by default - #5070
Fix Windows CI's Powershell not propagate error by default#5070Cloud0310 wants to merge 1 commit into
Conversation
|
Nah, another OpenSSL build problem..... |
|
@Cloud0310 The CI is failing because now with Git Bash, Perl is running under Git Perl instead of Strawberry under Windows. I am afraid we have to do early returns by hand in |
bdb8834 to
3300b57
Compare
|
@rami3l Fixed and added note for this thanks for further bug diagnosis. |
|
Hm, have you considered using |
Good idea, would love to try. |
3300b57 to
8926865
Compare
|
I've pinned to PowerShell on Windows actions, and added comments about this choice in case of future confusion. |
|
Feel free to ignore this if you don't want to do any bigger refactoring but seeing the repeated use of shell: pwsh -Command $ErrorActionPreference='stop'; $PSNativeCommandUseErrorActionPreference=$true; & '{0}' |
Previous Windows GNU and MSVC target on CI/CD has different report. This is what I found when dealing with CI/CD errors on #5056.
This is due to the default shell for running GNU target on Windows is
pwsh, and its not exiting upon first error, causing checking failures being ignored.Note: assisted by codex GPT-6.