fix(config): improve error handling in Cfg::list_toolchains() - #5068
Merged
Conversation
rami3l
commented
Sep 11, 2026
rami3l
force-pushed
the
fix/error-handling-toolchain-list
branch
4 times, most recently
from
September 11, 2026 13:31
7fb9f17 to
3457ff5
Compare
rami3l
marked this pull request as ready for review
September 11, 2026 13:40
rami3l
marked this pull request as draft
September 11, 2026 13:47
rami3l
force-pushed
the
fix/error-handling-toolchain-list
branch
from
September 11, 2026 13:49
3457ff5 to
784946f
Compare
rami3l
marked this pull request as ready for review
September 11, 2026 13:50
djc
reviewed
Sep 11, 2026
rami3l
force-pushed
the
fix/error-handling-toolchain-list
branch
from
September 11, 2026 14:43
784946f to
a755461
Compare
rami3l
force-pushed
the
fix/error-handling-toolchain-list
branch
3 times, most recently
from
September 12, 2026 07:41
4f4dc54 to
e09a4c9
Compare
This comment has been minimized.
This comment has been minimized.
djc
approved these changes
Sep 12, 2026
rami3l
force-pushed
the
fix/error-handling-toolchain-list
branch
from
September 12, 2026 11:26
e09a4c9 to
71671c4
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
rami3l
force-pushed
the
fix/error-handling-toolchain-list
branch
from
September 12, 2026 11:29
71671c4 to
0001952
Compare
rami3l
enabled auto-merge
September 12, 2026 11:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is another problem that I have noticed when working on rust-lang/goals#736.