Repository navigation
Add regression test for issue 6300 - #7164
Merged
Merged
Conversation
It looks like this issue has been fixed, so add a test to ensure we never regress. You may ask _when_ this was fixed, the best I could do was bisect to a merge commit: d97c4fb, via: # use --first-parent so we don't try and build commits that were # originally added in rust-lang/rust, since it's a pain to find the # correct toolchain to build those against $ git bisect start --term-new=fixed --term-old=broken --first-parent main 46cb7d3 $ git bisect run ./bisect.sh Where `bisect.sh` is: #!/usr/bin/env bash set -o errexit if ! cargo build --quiet --bin rustfmt then echo "failed to build" >&2 # exit: magic code that tells git-bisect to skip this commit (see # git-bisect(1)) exit 125 fi export LD_LIBRARY_PATH="$(rustc --print sysroot)/lib${LD_LIBRARY_PATH:+:${LD_LIBRARY_PATH}}" # reverse the exit code: the basis of 'git bisect' is that the 'new' commit is # bad, the 'old' commit is good (e.g. there's a bug in HEAD but not HEAD~4, # which commit introduced that?). But we want the _opposite_ ! ./target/debug/rustfmt --check ./samples/bugs.rs >/dev/null References: rust-lang#6300
ytmimi
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like this issue has been fixed, so add a test to ensure we
never regress.
You may ask when this was fixed, the best I could do was bisect to
a merge commit: d97c4fb, via:
Where
bisect.shis:Closes: #6300