Repository navigation
Return io errors from print_diff instead of panicking on broken pipe - #7159
Closed
integral-830 wants to merge 1 commit into
Closed
integral-830 wants to merge 1 commit into
integral-830 wants to merge 1 commit into
Conversation
rustbot
added
the
S-waiting-on-review
ytmimi
added
the
S-on-hold
Contributor
|
Thank you for the PR. Marking this as on hold until a minimal reproduction is provided that we can turn into a test case to verify the fix. |
ytmimi
added
S-waiting-on-author
ytmimi
marked this pull request as draft
October 6, 2026 06:24
Member
|
Moderation note: temporarily closing this user's PRs due to rust-lang/rust#163860 (comment) |
rustbot
removed
the
S-waiting-on-author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7158
OutputWriter::writeln unwrapped the results of writing to stdout, so a closed
pipe turned into a panic (reported on Windows, where BrokenPipe is returned
instead of the process being killed).
writeln and print_diff now return io::Result, and DiffEmitter propagates the
error with
?. The non-terminal path uses writeln! on stdout instead ofprintln!, which would panic on a failed write too.
I could only test on macOS, so I haven't tried this on Windows.