Repository navigation
fix: prevent newlines around quotes in macro invocations - #7157
Open
penguinawesome1 wants to merge 1 commit into
Open
penguinawesome1 wants to merge 1 commit into
penguinawesome1 wants to merge 1 commit into
Conversation
rustbot
added
the
S-waiting-on-review
penguinawesome1
force-pushed
the
macro-string-indent
branch
from
October 4, 2026 03:48
7bc8e47 to
2d6da3a
Compare
jieyouxu
reviewed
Oct 4, 2026
Comment on lines
+303
to
+315
| // Handle special case where there is one argument, | ||
| // a string literal containing a newline. | ||
| if let [MacroArg::Expr(expr)] = arg_vec.as_slice() { | ||
| if let ast::ExprKind::Lit(lit) = expr.kind { | ||
| if lit.kind == LitKind::Str && lit.symbol.as_str().contains("\n") { | ||
| let rw = format!("{}(\"{}\")", macro_name, lit.symbol); | ||
| return match position { | ||
| MacroPosition::Item => Ok(format!("{};", rw)), | ||
| _ => Ok(rw), | ||
| }; | ||
| } | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Remark: this feels very special-cased and somewhat strange to me. I agree the existing formatting doesn't seem great, but I'm not convinced special-casing here makes sense either.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes formatting for string literals that contain a newline in macro invocations.
Closes #5029
Used to review Rust syntax and for a sanity check (reminded me to use
as_strinstead ofto_string).