Skip to content

Upgrade to hyper 1 and reqwest 0.13#2475

Open
djc wants to merge 2 commits into
rust-lang:masterfrom
djc:upgrade-reqwest
Open

Upgrade to hyper 1 and reqwest 0.13#2475
djc wants to merge 2 commits into
rust-lang:masterfrom
djc:upgrade-reqwest

Conversation

@djc

@djc djc commented May 12, 2026

Copy link
Copy Markdown
Contributor

This was triggered initially by #t-release > Producing a smaller alternative to `rustc-{version}-src` discussing that there were many copies of OpenSSL included, which led me to wonder whether we could use rustls for some of these. reqwest 0.13 defaults to using rustls for TLS by default.

I also generally think it's better to keep dependencies up to date, including (but not only) because it limits duplicate dependencies.

@djc djc marked this pull request as draft May 12, 2026 12:52
@djc

djc commented May 12, 2026

Copy link
Copy Markdown
Contributor Author

This fails to build aws-lc-sys:

#21 13.84   --- stderr
#21 13.84 
#21 13.84   thread 'main' (1124) panicked at /root/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/aws-lc-sys-0.40.0/builder/cc_builder.rs:731:9:
#21 13.84   ### COMPILER BUG DETECTED ###
#21 13.84   Your compiler (cc) is not supported due to a memcmp related bug reported in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95189. We strongly recommend against using this compiler. 

Dockerfile is building on top of ubuntu:20.04 which is fairly old. See

@djc

djc commented May 12, 2026

Copy link
Copy Markdown
Contributor Author

This unfortunately (still) results in duplicate reqwest versions, due to

@djc djc force-pushed the upgrade-reqwest branch from fdfe4e3 to 520715c Compare May 26, 2026 11:22
@djc djc marked this pull request as ready for review May 26, 2026 11:23

@Kobzol Kobzol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look simple enough, but at the moment this increases the dependency count from 464 to 488. I'm not sure if it's worth merging it at least until the object_store crate releases a new version.

@djc djc force-pushed the upgrade-reqwest branch from 520715c to 436407d Compare June 22, 2026 13:57
@djc

djc commented Jun 22, 2026

Copy link
Copy Markdown
Contributor Author

The changes look simple enough, but at the moment this increases the dependency count from 464 to 488. I'm not sure if it's worth merging it at least until the object_store crate releases a new version.

Added a commit that upgrades object_store to 0.14... but that further increases the dependency count by 15 (in the lockfile). It does at least get rid of reqwest 0.12.

Sources:

  • object_store depends on rand 0.10, but there are still a few edges on rand 0.9 (including via termwiz, which hasn't had a release in quite a while)
  • object_store depends on nix 0.31, but there are still edges on nix 0.29 (all via termwiz AFAICT)
  • object_store depends on itertools 0.15 but the site still depends on itertools 0.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants