Fix invalid link in lowering.md and typo in thir.md - #3005
Open
000wahab000 wants to merge 1 commit into
Open
Conversation
Collaborator
|
Thanks for the PR. If you have write access, feel free to merge this PR if it does not need reviews. You can request a review using |
rustbot
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
000wahab000
force-pushed
the
fix-lowering-link-and-thir-typo
branch
from
September 5, 2026 16:35
926f32b to
74c8881
Compare
| The implementation of AST lowering is in the [`rustc_ast_lowering`] crate. | ||
| The entry point is [`lower_to_hir`], which retrieves the post-expansion AST | ||
| and resolver data from [`TyCtxt`] and builds the [`hir::Crate`] for the whole crate. | ||
| and resolver data from [`TyCtxt`] and builds the [HIR](../hir.md) for the whole crate. |
Member
There was a problem hiding this comment.
I think this paragraph may need a bit more updating than just replacing the dead hir::Crate link. Since rust-lang/rust#157296, lower_to_hir is no longer a public entry point. Also, after rust-lang/rust#142830, it lowers an individual HIR owner rather than the whole crate.
it might be better to keep only the typo fix in thir.md in this PR and update hir/lowering.md more comprehensively in a separate PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3004.