Repository navigation
Rollup of 23 pull requests - #165243
Rollup of 23 pull requests#165243
Conversation
…` (part 1) The macro is duplicated in each file to allow the diff to compare changes with the previous implementation.
Co-authored-by: Mark Rousskov <mark.simulacrum@gmail.com>
In the `br_string` closure, `s` was non-empty if and only if it was created using `format!`; add the extra space directly in that `format!` invocation.
The langref says that > The first argument is a pointer from which to load a function pointer So whenever we load something that is not a function pointer, we should not use `type_checked_load`
Normalizing a field type can fail during const-eval validation if it contains an unsatisfied projection alias. Fall back to a delayed bug instead of panicking with an ICE, and conservatively assume the field is inhabited.
This avoids depending on LLVM's struct types to determine the size of the array/pointer element. Co-Authored-By: Bee <b@beetr.ee>
… if there's no `dyn Trait` field to point at
and just have a separate `type_packed_struct` helper for the one case where we don't pass `false` to that function.
Use a macro to reduce duplication in `core/src/num/f{16,32,64,128}.rs` (part 1)
Now there are 4 primitive floating point types, the code for each method/constant is duplicated 4 times, once on each type. This PR begins reducing the duplication by moving the code in `impl f{16,32,64,128}` in `core` into a `float_impl!` macro, similar to the existing `int_impl!` and `uint_impl!` macros (which are used for 6 primitive types each). To reduce merge conflicts and make this easier to review, I'm going to move the items in chunks: this PR just moves the associated constants.
The PR is split into two commits, with the first commit having the macro duplicated in all 4 individual float files so that the diff can compare the macro with the original implementation.
rust-bors
Bot
removed
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
Rollup of 23 pull requests try-job: dist-various-1 try-job: test-various try-job: test-x86_64-gnu-aux try-job: test-x86_64-msvc-1 try-job: test-x86_64-mingw-1 try-job: test-i686-msvc try-job: test-armhf-gnu try-job: test-x86_64-gnu-llvm-22-3 try-job: test-aarch64-msvc-2
rust-bors
Bot
added
S-waiting-on-author
|
PR #165184, which is a member of this rollup, was unapproved. This rollup was thus unapproved. |
|
@bors r=JonathanBrouwer |
rust-bors
Bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors
Bot
added
merged-by-bors
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 2687a50 (parent) -> f9ceb4a (this PR) Test differencesShow 2450 test diffsStage 1
Stage 2
Additionally, 2426 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard f9ceb4a4d45a471eed7bd8c40dddb7c38e749e21 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (f9ceb4a): comparison URL. Overall result: ❌ regressions - please read:Our benchmarks found a performance regression caused by this PR. Next Steps:
@rustbot label: +perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (secondary -2.6%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary 2.0%, secondary 5.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 487.481s -> 492.484s (1.03%) |
|
📌 Perf builds for each rolled up PR:
parent commit: 2687a50235 In the case of a perf regression, run the following command with the SHAs of each PR you suspect might be the cause: |
|
@rust-timer triage all |
Running triage with 2 benchmarksTriage only executes the benchmarks on rollup members, that were changed significantly on the rollup.
#163410 3b99415 Use a macro to reduce duplication in
|
Successful merges:
core/src/num/f{16,32,64,128}.rs(part 1) #163410 (Use a macro to reduce duplication incore/src/num/f{16,32,64,128}.rs(part 1))type.checked.loadfor function pointers #164290 (virtual function elimination: only usetype.checked.loadfor function pointers)is_doc_keyword_or_attributeandis_rustc_doc_primitive#165197 (Inline usages ofis_doc_keyword_or_attributeandis_rustc_doc_primitive)point_at_dyn_trait_in_field_defif there's nodyn Traitfield to point at #165209 (Don't ICE when making diagnostic inpoint_at_dyn_trait_in_field_defif there's nodyn Traitfield to point at)SBValuechildren #165228 (Fix error output for invalidSBValuechildren)Celldoc #153633 (feat: improveCelldoc)abort_immediatetocrash#164730 (core: Renameabort_immediatetocrash)subslice_range#164937 (Add example for misaligned elements insubslice_range)gca!for path const args that use generic params #165035 (Suggestgca!for path const args that use generic params)TypeErrCtxt::report_inference_failure()#165158 (Tiny optimization toTypeErrCtxt::report_inference_failure())feature(stdarch_loongarch)for bootstrap #165225 (LoongArch: Restorefeature(stdarch_loongarch)for bootstrap)Failed merges:
r? @ghost
Create a similar rollup