Migrate stable-specific run-make tests to UI tests by Kobzol · Pull Request #164802 · rust-lang/rust

Kobzol · 2026-10-23T14:21:10Z

Enabled by #163664.

I still kept the stable_bare_rustc function, as it could be genuinely useful (just not in the way it was used in run-make tests so far).

Should help unblock #162848.

Note that the comment for the unstable target feature test was wrong (#163428 (comment)).

r? jieyouxu

…to a UI test

…est to a UI test

…UI test

jieyouxu · 2026-10-25T02:16:13Z

 //@ needs-target-std
 //@ ignore-backends: gcc

+//@ normalize-stderr: "dev release channel" -> "nightly release channel"


~~Wait, do we actually need this normalization rule? That seems strange?~~

~~I don't think we need this for ui tests, run-make tests may have had to do their own channel normalizations, but ui tests should already have this done at a test suite level?~~

EDIT: apparently we do, I thought this was already normalized but it wasn't, which is curious 🤔

View changes since the review

Oh, it's because only https://doc.rust-lang.org/error_codes/E0554.html mentions the actual channel in the diagnostics, intriguing.

jieyouxu

Thanks, ~~you can r=me after addressing #164802 (comment).~~

View changes since this review

jieyouxu · 2026-10-25T02:42:06Z

@bors r+ rollup

rust-bors · 2026-10-25T02:42:09Z

📌 Commit ababbd4 has been approved by jieyouxu

It is now in the queue for this repository.

Migrate stable-specific run-make tests to UI tests Enabled by rust-lang#163664. I still kept the `stable_bare_rustc` function, as it could be genuinely useful (just not in the way it was used in run-make tests so far). Should help unblock rust-lang#162848. Note that the comment for the unstable target feature test was wrong (rust-lang#163428 (comment)). r? jieyouxu

Rollup of 12 pull requests Successful merges: - #164834 (miri subtree update) - #164869 (rustc_codegen_gcc subtree update) - #157123 (library: optimize truncate method) - #159916 (Optimize `str.escape_default().to_string()`) - #164508 (ping me for layout invariant changes) - #164758 (Update dependency jinja2 to v3.1.6 [SECURITY]) - #164802 (Migrate stable-specific run-make tests to UI tests) - #164836 (Add regression test for #162109) - #164857 (Do not checkout Cargo for bootstrap tests) - #164868 (Fix skipping library build with `--keep-stage[-std]`) - #164872 (cg_llvm: clarify Send / Sync story for modules) - #164881 (Add FIXME comments to `from_ascii_bytes_radix_impl`)

jieyouxu · 2026-10-25T05:15:21Z

Hm, tests/ui/traits/const-traits/const-supertrait-unstable.rs#stable-enabled failed in #164885 (comment) because

10	LL | trait Bar: [const] Foo {}
11	   | ^^^^^^^^^^^^^^^^^^^^^^^^^
12	
-	error[E0554]: `#![feature]` may not be used on the nightly release channel
+	error[E0554]: `#![feature]` may not be used on the stable release channel
14	  --> $DIR/const-supertrait-unstable.rs:18:30
15	   |
16	LL | #![cfg_attr(feature_enabled, feature(const_trait_impl))]

jieyouxu · 2026-10-25T05:15:51Z

+LL | trait Bar: [const] Foo {}
+   | ^^^^^^^^^^^^^^^^^^^^^^^^^
+
+error[E0554]: `#![feature]` may not be used on the nightly release channel


This would be wrong / produce the diff as nightly because we pipe the release channel to the diagnostics 🤔 In some sense it's orthogonal to whether #![feature] can be used when we //@ act-as-stable

View changes since the review

Yeah, you can still have "stable-like" behavior, even though the actual channel string is whatever.

jieyouxu · 2026-10-25T05:16:51Z

@bors r-

rust-bors · 2026-10-25T05:16:58Z

This pull request was unapproved.

View changes since this unapproval

Kobzol · 2026-10-25T12:07:54Z

@bors try jobs=test-x86_64-gnu-stable

Migrate stable-specific run-make tests to UI tests try-job: test-x86_64-gnu-stable

rust-bors · 2026-10-25T12:59:37Z

💔 Test for 106dc8e failed: CI. Failed job:

try - test-x86_64-gnu-stable (web logs, enhanced plaintext logs)

Kobzol · 2026-10-25T13:04:16Z

@bors try jobs=test-x86_64-gnu-stable

Migrate stable-specific run-make tests to UI tests try-job: test-x86_64-gnu-stable

rust-bors · 2026-10-25T15:35:03Z

☀️ Try build successful (CI)
Build commit: c2114dd (c2114ddd52e91d424130ca9501e2b9511f3798bb)
Base parent: dc44e7f (dc44e7f2c436b6041742e138b9c2176f093196d5)

Kobzol · 2026-10-25T16:49:05Z

The channel is hardcoded into the compiler binary, so unless we add some testing only dynamic override, we likely can't normalize much better than just turning stable and dev into nightly.. So I think that's good enough for now.

@bors r=jieyouxu

rust-bors · 2026-10-25T16:49:08Z

📌 Commit cbdd3f3 has been approved by jieyouxu

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 5. This pull request will be tested once the tree is reopened.

Reason for tree closure: test-aarch64-apple-macos-26-2 out of disk space

Migrate stable-specific run-make tests to UI tests Enabled by rust-lang#163664. I still kept the `stable_bare_rustc` function, as it could be genuinely useful (just not in the way it was used in run-make tests so far). Should help unblock rust-lang#162848. Note that the comment for the unstable target feature test was wrong (rust-lang#163428 (comment)). r? jieyouxu

Migrate the missing-unstable-trait-bound test from a run-make test …

04d2625

…to a UI test

rustbot assigned jieyouxu Oct 23, 2026

rustbot added A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 23, 2026

This comment has been minimized.

Sign in to view

Kobzol force-pushed the stable-ui-tests branch from cee6920 to e1d9080 Compare October 23, 2026 14:45

This comment has been minimized.

Sign in to view

Kobzol mentioned this pull request Oct 23, 2026

do not complain about unstable target features on nightly #163428

Merged

This comment has been minimized.

Sign in to view

Kobzol added 3 commits October 23, 2026 21:20

Migrate the const-trait-stable-toolchain test from a run-make test …

2cb98f8

…to a UI test

Migrate the issue-149402-no-suggest-unstable test from a run-make t…

30a01ab

…est to a UI test

Migrate the unstable-target-feature test from a run-make test to a …

ababbd4

…UI test

Kobzol force-pushed the stable-ui-tests branch from 88a3eb5 to ababbd4 Compare October 23, 2026 19:20

jieyouxu reviewed Oct 25, 2026

View reviewed changes

jieyouxu approved these changes Oct 25, 2026

View reviewed changes

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 25, 2026

jieyouxu mentioned this pull request Oct 25, 2026

Rollup of 12 pull requests #164885

Closed

jieyouxu reviewed Oct 25, 2026

View reviewed changes

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 25, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Oct 25, 2026

Auto merge of #164802 - Kobzol:stable-ui-tests, r=<try>

106dc8e

Migrate stable-specific run-make tests to UI tests try-job: test-x86_64-gnu-stable

This comment has been minimized.

Sign in to view

Also normalize "stable release channel"

cbdd3f3

Kobzol force-pushed the stable-ui-tests branch from c71bbdf to cbdd3f3 Compare October 25, 2026 13:04

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Oct 25, 2026

Auto merge of #164802 - Kobzol:stable-ui-tests, r=<try>

c2114dd

Migrate stable-specific run-make tests to UI tests try-job: test-x86_64-gnu-stable

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 25, 2026

JonathanBrouwer mentioned this pull request Oct 25, 2026

Rollup of 19 pull requests #164922

Closed

JonathanBrouwer mentioned this pull request Oct 25, 2026

Rollup of 19 pull requests #164923

Open

Conversation

Kobzol commented Oct 23, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

jieyouxu Oct 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jieyouxu Oct 25, 2026

Choose a reason for hiding this comment

Uh oh!

jieyouxu left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jieyouxu commented Oct 25, 2026

Uh oh!

rust-bors Bot commented Oct 25, 2026

Uh oh!

jieyouxu commented Oct 25, 2026

Uh oh!

jieyouxu Oct 25, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Kobzol Oct 25, 2026

Choose a reason for hiding this comment

Uh oh!

jieyouxu commented Oct 25, 2026

Uh oh!

rust-bors Bot commented Oct 25, 2026

Uh oh!

Kobzol commented Oct 25, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors Bot commented Oct 25, 2026

Uh oh!

This comment has been minimized.

Kobzol commented Oct 25, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Oct 25, 2026

Uh oh!

Kobzol commented Oct 25, 2026

Uh oh!

rust-bors Bot commented Oct 25, 2026

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Kobzol commented Oct 23, 2026 •

edited by rustbot

Loading

jieyouxu Oct 25, 2026 •

edited

Loading

jieyouxu left a comment •

edited

Loading

jieyouxu Oct 25, 2026 •

edited by rustbot

Loading