Skip to content

Add str::as_ascii_mut and slice::as_ascii_mut - #164242

Open
RegularCoder239 wants to merge 1 commit into
rust-lang:mainfrom
RegularCoder239:as_ascii_mut
Open

Add str::as_ascii_mut and slice::as_ascii_mut#164242
RegularCoder239 wants to merge 1 commit into
rust-lang:mainfrom
RegularCoder239:as_ascii_mut

Conversation

@RegularCoder239

@RegularCoder239 RegularCoder239 commented Oct 13, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

View all comments

As requested by rust-lang/libs-team#910 (comment), this pr adds str::as_ascii_mut, slice::as_ascii_mut and unsafe unchecked variants.

These methods are mutable variants of str::as_ascii and slice::as_ascii.

r?scottmcm

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 13, 2026
@rustbot

rustbot commented Oct 13, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the pull request, and welcome! The Rust Project has assigned @Mark-Simulacrum (or someone else) to review your changes, you should hear from them (or someone else) within the next two weeks.

Please see the contribution instructions and our LLM policy for more information.

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: libs
  • libs expanded to 12 candidates
  • Random selection from JohnTitor, Mark-Simulacrum

@rustbot rustbot assigned scottmcm and unassigned Mark-Simulacrum Oct 13, 2026
scottmcm
scottmcm requested changes Oct 13, 2026
View reviewed changes
Comment thread library/core/src/slice/ascii.rs Outdated
Comment thread library/core/src/slice/ascii.rs Outdated
Comment thread library/core/src/str/mod.rs
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 13, 2026
@rustbot

rustbot commented Oct 13, 2026

Copy link
Copy Markdown
Collaborator

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@RegularCoder239

RegularCoder239 commented Oct 13, 2026

Copy link
Copy Markdown
Contributor Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 13, 2026
asquared31415
asquared31415 reviewed Oct 13, 2026
View reviewed changes
Comment thread library/core/src/str/mod.rs Outdated
@RegularCoder239

RegularCoder239 commented Oct 13, 2026

Copy link
Copy Markdown
Contributor Author

@rustbot ready

scottmcm
scottmcm reviewed Oct 19, 2026
View reviewed changes
Comment thread library/core/src/slice/ascii.rs Outdated
scottmcm
scottmcm reviewed Oct 19, 2026
View reviewed changes
Comment thread library/core/src/str/mod.rs Outdated
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 19, 2026
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 20, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
scottmcm
scottmcm reviewed Oct 22, 2026
View reviewed changes
Comment thread library/core/src/str/mod.rs Outdated

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@scottmcm scottmcm Awaiting requested review from scottmcm
1 more reviewer
@asquared31415 asquared31415 asquared31415 left review comments
Reviewers whose approvals may not affect merge requirements

Requested changes must be addressed to merge this pull request.

Assignees

@scottmcm scottmcm

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@RegularCoder239 @rustbot @rust-log-analyzer @scottmcm @asquared31415 @Mark-Simulacrum