Repository navigation
bootstrap: add an rpath to LLVM library for LLVM tools - #164134
Open
danieljhkim wants to merge 1 commit into
Open
danieljhkim wants to merge 1 commit into
danieljhkim wants to merge 1 commit into
Conversation
danieljhkim
marked this pull request as ready for review
October 11, 2026 03:38
Collaborator
|
This PR changes how LLVM is built. Consider updating src/bootstrap/download-ci-llvm-stamp. |
Collaborator
|
Thanks for the pull request, and welcome! The Rust Project has assigned @Mark-Simulacrum (or someone else) to review your changes, you should hear from them (or someone else) within the next two weeks. Please see the contribution instructions and our LLM policy for more information. Why was this reviewer chosen?The reviewer was selected based on:
|
danieljhkim
force-pushed
the
fix-rust-objcopy-rpath
branch
from
October 11, 2026 03:40
cc8d7a0 to
ec60f65
Compare
Member
|
r? kobzol Thanks for the PR. Two remarks:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #164063 by adding rpath to the LLVM tool executables on both Linux and macOS, using the same approach as Lld::run.
This PR is now written by a human, resubmitting #164064 which was diagnosed and written by Claude.
Validation:
macOS
linux