Fix debug assert failure in `note_obligation_cause_code_inner` by RuleOfSix · Pull Request #163912 · rust-lang/rust

RuleOfSix · 2026-10-07T01:41:13Z

Applied the recommended fix and turned the crash test into a regression test. Closes #139381.

r? lcnr

rustbot · 2026-10-07T01:41:17Z

This PR changes a file inside tests/crashes. If a crash was fixed, please move into the corresponding ui subdir and add 'Fixes #' to the PR description to autoclose the issue upon merge.

rustbot · 2026-10-07T01:41:20Z

Thanks for the pull request, and welcome! The Rust Project has assigned @lcnr (or someone else) to review your changes, you should hear from them (or someone else) within the next two weeks.

Please see the contribution instructions and our LLM policy for more information.

lcnr · 2026-10-07T07:06:36Z

thanks, one nit, then r=me

RuleOfSix · 2026-10-07T13:57:00Z

Fixed :)

lcnr · 2026-10-07T13:58:54Z

@bors r+ rollup

rust-bors · 2026-10-07T13:58:57Z

📌 Commit 6321136 has been tentatively approved by lcnr

It will be put into the queue for this repository once PR CI succeeds.

Fix debug assert failure in `note_obligation_cause_code_inner` Applied the recommended fix and turned the crash test into a regression test. Closes rust-lang#139381. r? lcnr

JonathanBrouwer · 2026-10-08T05:38:03Z

💔 I suspect this PR failed tests as part of a rollup
@bors r-

After fixing the problem, consider running a try job for the failed job before re-approving.

Link to failure: #163963 (comment)

rust-bors · 2026-10-08T05:38:08Z

This pull request was unapproved.

View changes since this unapproval

… old solver and update `incorrect-skip-binder-for-item-bound` test accordingly.

rustbot · 2026-10-08T22:43:13Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

RuleOfSix · 2026-10-08T22:48:08Z

@rustbot ready

CI failure was due to a test for this crash that existed on main but was added after this branched off of main. I rebased, updated the test's [old] revision to test for the fix instead of the crash, and removed the other test for this problem that was on this branch, as it is now redundant.

lcnr, could you run the try job for me?

JonathanBrouwer · 2026-10-09T07:56:35Z

@bors try jobs=test-x86_64-gnu-next-trait-solver-polonius

Fix debug assert failure in `note_obligation_cause_code_inner` try-job: test-x86_64-gnu-next-trait-solver-polonius

rust-bors · 2026-10-09T08:56:26Z

☀️ Try build successful (CI)
Build commit: 1f08a06 (1f08a0682c8b4ee6bf53d2520e9a4864f27ffd20)
Base parent: 76c9095 (76c90957b7e422c4b9c45192b0197214d7de5a54)

JonathanBrouwer · 2026-10-09T08:57:39Z

@bors r=lcnr

rust-bors · 2026-10-09T08:57:43Z

📌 Commit 2f9523b has been approved by lcnr

It is now in the queue for this repository.

Fix debug assert failure in `note_obligation_cause_code_inner` Applied the recommended fix and turned the crash test into a regression test. Closes rust-lang#139381. r? lcnr

…uwer Rollup of 14 pull requests Successful merges: - #162652 (Syntactically reject leading parenthesized precise capturing lists in bare trait object types (`(use<…>)+`)) - #163337 (MIR move elimination [3/6]: PreciseLiveness) - #163954 (fix(bootstrap/darwin): fix rpath for distributed LLD) - #163193 (cfi: mangle `f128` as `e` rather than `g` on platforms without `_Float128`) - #163634 (move overflow lint computation into decorator) - #163666 (Updates the expect message library/core/src/time.rs) - #163727 (rigid aliases to non-rigid for fully normalized check) - #163745 (replace `fully_monomorphized` with `cx.typing_env()`) - #163912 (Fix debug assert failure in `note_obligation_cause_code_inner`) - #163972 (const-eval: ICE when we hit a non-const fn) - #164000 (When mentioning that closure doesn't implement trait, point at closure) - #164007 ([rustdoc] Prefer local paths over remote ones when foreign item is locally reexported) - #164017 (cg_llvm: Avoid some explicit casts to `*const c_char`) - #164025 (Less `CanonicalVarValues`)

Fix debug assert failure in `note_obligation_cause_code_inner` Applied the recommended fix and turned the crash test into a regression test. Closes rust-lang#139381. r? lcnr

…uwer Rollup of 14 pull requests Successful merges: - #162652 (Syntactically reject leading parenthesized precise capturing lists in bare trait object types (`(use<…>)+`)) - #163337 (MIR move elimination [3/6]: PreciseLiveness) - #163954 (fix(bootstrap/darwin): fix rpath for distributed LLD) - #163193 (cfi: mangle `f128` as `e` rather than `g` on platforms without `_Float128`) - #163634 (move overflow lint computation into decorator) - #163666 (Updates the expect message library/core/src/time.rs) - #163727 (rigid aliases to non-rigid for fully normalized check) - #163745 (replace `fully_monomorphized` with `cx.typing_env()`) - #163912 (Fix debug assert failure in `note_obligation_cause_code_inner`) - #163950 (don't treat inherited opaques as defining) - #164000 (When mentioning that closure doesn't implement trait, point at closure) - #164007 ([rustdoc] Prefer local paths over remote ones when foreign item is locally reexported) - #164017 (cg_llvm: Avoid some explicit casts to `*const c_char`) - #164025 (Less `CanonicalVarValues`)

…uwer Rollup of 24 pull requests Successful merges: - #161998 ( Support type-relative assoc item paths in generic param defaults & const param types) - #162106 (Helpful suggestions for incorrect address-of mutability (2)) - #162652 (Syntactically reject leading parenthesized precise capturing lists in bare trait object types (`(use<…>)+`)) - #163337 (MIR move elimination [3/6]: PreciseLiveness) - #163938 (-Zassumptions-on-binders: rewrite alias outlives constraints more goodly) - #163939 (Better debug impls for some assumptions on binders types) - #163954 (fix(bootstrap/darwin): fix rpath for distributed LLD) - #163956 (Pass the unremapped path to the `rustc` invocation for doctests) - #164042 (Allow testing cg-gcc on any target) - #162443 (Do not retain `Normalization` goal errors in nested goals for `BestObligationVisitor:: non_trivial_candidates `) - #162908 (Fix - const parameters rejected when identical) - #163193 (cfi: mangle `f128` as `e` rather than `g` on platforms without `_Float128`) - #163634 (move overflow lint computation into decorator) - #163666 (Updates the expect message library/core/src/time.rs) - #163727 (rigid aliases to non-rigid for fully normalized check) - #163745 (replace `fully_monomorphized` with `cx.typing_env()`) - #163912 (Fix debug assert failure in `note_obligation_cause_code_inner`) - #163950 (don't treat inherited opaques as defining) - #163972 (const-eval: ICE when we hit a non-const fn) - #164000 (When mentioning that closure doesn't implement trait, point at closure) - #164007 ([rustdoc] Prefer local paths over remote ones when foreign item is locally reexported) - #164008 (properly ignore the current goal's usages) - #164017 (cg_llvm: Avoid some explicit casts to `*const c_char`) - #164025 (Less `CanonicalVarValues`)

Rollup merge of #163912 - RuleOfSix:ice-escaping-bounds, r=lcnr Fix debug assert failure in `note_obligation_cause_code_inner` Applied the recommended fix and turned the crash test into a regression test. Closes #139381. r? lcnr

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 7, 2026

rustbot assigned lcnr Oct 7, 2026

lcnr reviewed Oct 7, 2026

View reviewed changes

Comment thread tests/ui/higher-ranked/note-obligation-cause-ice-139381.stderr Outdated

RuleOfSix force-pushed the ice-escaping-bounds branch from b838019 to 6321136 Compare October 7, 2026 13:55

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 7, 2026

jhpratt mentioned this pull request Oct 8, 2026

Rollup of 11 pull requests #163961

Closed

JonathanBrouwer mentioned this pull request Oct 8, 2026

Rollup of 11 pull requests #163963

Closed

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 8, 2026

Fix debug assert failure in note_obligation_cause_code_inner on the…

2f9523b

… old solver and update `incorrect-skip-binder-for-item-bound` test accordingly.

RuleOfSix force-pushed the ice-escaping-bounds branch from 6321136 to 2f9523b Compare October 8, 2026 22:43

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 8, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Oct 9, 2026

Auto merge of #163912 - RuleOfSix:ice-escaping-bounds, r=<try>

1f08a06

Fix debug assert failure in `note_obligation_cause_code_inner` try-job: test-x86_64-gnu-next-trait-solver-polonius

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 9, 2026

JonathanBrouwer mentioned this pull request Oct 9, 2026

Rollup of 14 pull requests #164026

Closed

JonathanBrouwer mentioned this pull request Oct 9, 2026

Rollup of 14 pull requests #164027

Closed

JonathanBrouwer mentioned this pull request Oct 9, 2026

Rollup of 14 pull requests #164039

Closed

JonathanBrouwer mentioned this pull request Oct 9, 2026

Rollup of 24 pull requests #164052

Merged

rust-bors Bot merged commit 9ae1a8a into rust-lang:main Oct 9, 2026
15 checks passed

rustbot added this to the 1.101.0 milestone Oct 9, 2026

Conversation

RuleOfSix commented Oct 7, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Oct 7, 2026

Uh oh!

rustbot commented Oct 7, 2026

Uh oh!

Uh oh!

lcnr commented Oct 7, 2026

Uh oh!

RuleOfSix commented Oct 7, 2026

Uh oh!

lcnr commented Oct 7, 2026

Uh oh!

rust-bors Bot commented Oct 7, 2026

Uh oh!

JonathanBrouwer commented Oct 8, 2026

Uh oh!

rust-bors Bot commented Oct 8, 2026

Uh oh!

rustbot commented Oct 8, 2026

Uh oh!

RuleOfSix commented Oct 8, 2026

Uh oh!

JonathanBrouwer commented Oct 9, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Oct 9, 2026

Uh oh!

JonathanBrouwer commented Oct 9, 2026

Uh oh!

rust-bors Bot commented Oct 9, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

RuleOfSix commented Oct 7, 2026 •

edited by rustbot

Loading