Repository navigation
Conversation
Some tests may need access to the constants.
Collaborator
|
The run-make-support library was changed cc @jieyouxu These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
rustbot
added
A-run-make
Collaborator
|
rustbot has assigned @petrochenkov. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Member
Author
|
@bors try jobs=test-x86_64-msvc*,test-various,test-arm-android,test-aarch64-apple-* |
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 6, 2026
std: Test the exit behavior of `abort` and `abort_immediate` try-job: test-x86_64-msvc* try-job: test-various try-job: test-arm-android try-job: test-aarch64-apple-*
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
tgross35
force-pushed
the
test-abort
branch
2 times, most recently
from
October 7, 2026 00:43
8fa366a to
8312c9f
Compare
This comment has been minimized.
This comment has been minimized.
rust-bors
Bot
added
S-waiting-on-author
This comment was marked as outdated.
This comment was marked as outdated.
tgross35
force-pushed
the
test-abort
branch
2 times, most recently
from
October 7, 2026 02:30
de8f110 to
8b5b91d
Compare
Member
Author
|
@bors try jobs=test-aarch64-apple-1,test-arm-android,test-various,test-x86_64-msvc-1,test-x86_64-mingw-* |
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 7, 2026
std: Test the exit behavior of `abort` and `abort_immediate` try-job: test-aarch64-apple-1 try-job: test-arm-android try-job: test-various try-job: test-x86_64-msvc-1 try-job: test-x86_64-mingw-*
This comment has been minimized.
This comment has been minimized.
Contributor
There has been discussion about possibly bringing `abort` into `core` with `abort_immediate` as a fallback. If this or other changes happen, we would want to make sure `abort` still raises SIGABRT. Since we don't seem to be asserting the exact exit behavior anywhere, add a test here.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There has been discussion about possibly bringing
abortintocorewith
abort_immediateas a fallback. If this or other changes happen,we would want to make sure
abortstill raises SIGABRT. Since we don'tseem to be asserting the exact exit behavior anywhere, add a test here.