Rollup of 7 pull requests by JonathanBrouwer · Pull Request #162627 · rust-lang/rust

JonathanBrouwer · 2026-09-11T09:08:36Z

Successful merges:

Rename various resolving functions for consistency, and document them #162126 (Rename various resolving functions for consistency, and document them)
Refactor HygieneEncodeContext #162520 (Refactor HygieneEncodeContext)
Skip linting unused braces for FunctionArg and MethodArg context for 2024 later #154373 (Skip linting unused braces for FunctionArg and MethodArg context for 2024 later )
Use attribute parser for #[non_exhaustive] attribute check #161482 (Use attribute parser for #[non_exhaustive] attribute check)
split macroless_generic_const_args in two #162541 (split macroless_generic_const_args in two)
The fuchsia team maintains riscv64gc-unknown-fuchsia #162549 (The fuchsia team maintains riscv64gc-unknown-fuchsia)
Fix i686-pc-windows-msvc platform support docs and target spec metadata #162577 (Fix i686-pc-windows-msvc platform support docs and target spec metadata)

…2024 edition

* Refactor `HygieneEncodeContext` * Review: remove comment outdated part * Review: return `raw_encode_syntax_context` as a free function * Review: small cleanups * Review: add comment about expansions data `Option` * Review: don't set explicit capacity * Review: return `queued` -> `latest` * Remove not needed changes * Fix `Rc` cloning * Return comment

As a Tier 1 (without host tools) target. - Fix an outdated claim that all T1 targets have host tools, since `i686-pc-windows-msvc` no longer does. - Remove a duplicate Tier 1 section. - Put `i686-pc-windows-msvc` under its own Tier 1 without host tools section.

We no longer ship host tools for this target.

@lcnr

…cnr,BoxyUwU Rename various resolving functions for consistency, and document them r? @lcnr or anyone in @rust-lang/initiative-trait-system-refactor This is all changes from https://github.com/rust-lang/rust/pull/160913/changes that are *just* renames. Updating that PR to be *just* the logic changes All interesting changes happened in `rustc_infer/src/infer/mod.rs` across all commits. Everything else is renames propagating through other files. The functions are now called: | before | after | note | |---|---|---| | `shallow_resolve_*` | (unchanged) `shallow_resolve_*` | Now with newly added docs. | | `resolve_vars_if_possible_*` | `deeply_resolve_ignoring_regions_*` | | | `eager_resolve_vars` | `deeply_resolve_via_unification_table` | moved onto the `InferCtxtLike` as an inherent method with default body. | | `fully_resolve` |`deeply_resolve_via_region_graph` | Resolves *with* regions and asserts that all variables are resolved at the end. Note, we only use this function 3x so the long name is ok, it shouldn't be your go-to anyway. | | `opportunistic_resolve_var` | | gone, same as `shalllow_resolve` now that we resolve to roots | > [!NOTE] > I've not used an LLM for any part of this PR, or any other PR I make. This includes any related work like research.

@petrochenkov

…nkov Refactor `HygieneEncodeContext` Some refactorings around `HygieneEncodeContext` with minor perf improvements, the most notable thing is that `Lock`s were removed. First part for rust-lang#161450. r? @petrochenkov

…d-braces-temp-scope-lite, r=oli-obk Skip linting unused braces for FunctionArg and MethodArg context for 2024 later Fixes rust-lang#154247 `unused_braces` is a AST level lint, but in Rust 2024 braces around function and method arguments can affect temporary drop scope. I tried to find a more complete fix for it, but seems all too heavy, which involve AST visitor or need `hir` related stuff. Instead of teaching this lint to reason about semantics, so it's better to stop linting those argument-position braces in 2024 later edition.

@JonathanBrouwer

…thanBrouwer Use attribute parser for `#[non_exhaustive]` attribute check Updates rust-lang#153101 r? @JonathanBrouwer

split `macroless_generic_const_args` in two Two's a crowd! But One's a lonely. Having `macroless_generic_const_args` apply to const items was quite annoying for users especially as we moved away from `type const` to just regular const items. We would quite commonly be "guessing wrong" with no easy way for users to opt out of `const ASSOC: usize = ...` being represented directly instead of an opaque body I just swapped any failing tests over to using macroless_const_item_generic_const_args, didnt look through the whole set :> We should probably bikeshed the feature name rn because it's currently inconsistent with what we wanted to rename all of the other gca features too :> Maybe this should be `gca_macroless_const_items` cc rust-lang#162540 r? khyperia

The fuchsia team maintains `riscv64gc-unknown-fuchsia` The fuchsia team maintains `riscv64gc-unknown-fuchsia` target (cc rust-lang#113739).

…r=khyperia Fix `i686-pc-windows-msvc` platform support docs and target spec metadata ## Summary Follow-up fixes to rust-lang#162288. - Fix an outdated claim that all T1 targets have host tools, since `i686-pc-windows-msvc` no longer does. - Remove a duplicate Tier 1 section. - Put `i686-pc-windows-msvc` under its own Tier 1 without host tools ## Context * `i686-pc-windows-msvc` Tier 1 (with host tools) => Tier 1 (without host tools) RFC: rust-lang/rfcs#3999 * cc rust-lang#158378

JonathanBrouwer · 2026-09-11T09:08:49Z

@bors r+ p=5

Trying commonly failed jobs
@bors try jobs=dist-various-1,test-various,test-x86_64-gnu-aux,test-x86_64-gnu-llvm-21-3,test-x86_64-msvc-1,test-aarch64-apple-1,test-aarch64-apple-2,test-x86_64-mingw-1,test-i686-msvc,test-armhf-gnu

rust-bors · 2026-09-11T09:08:52Z

📌 Commit 3fe9a35 has been approved by JonathanBrouwer

It is now in the queue for this repository.

Rollup of 7 pull requests try-job: dist-various-1 try-job: test-various try-job: test-x86_64-gnu-aux try-job: test-x86_64-gnu-llvm-21-3 try-job: test-x86_64-msvc-1 try-job: test-aarch64-apple-1 try-job: test-aarch64-apple-2 try-job: test-x86_64-mingw-1 try-job: test-i686-msvc try-job: test-armhf-gnu

rust-bors · 2026-09-11T09:35:44Z

This pull request was unapproved due to being closed.

rust-log-analyzer · 2026-09-11T11:29:35Z

The job test-aarch64-apple-2 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

 Documenting rustc_attr_parsing v0.0.0 (/Users/runner/work/rust/rust/compiler/rustc_attr_parsing)
warning: unresolved link to `rustc_type_ir::deeply_resolve`
    --> compiler/rustc_infer/src/infer/mod.rs:1268:38
     |
1268 |     /// or better [`deeply_resolve`](rustc_type_ir::deeply_resolve), if you can, which *does* resolve regions.
     |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no item named `deeply_resolve` in module `rustc_type_ir`
     |
     = note: `#[warn(rustdoc::broken_intra_doc_links)]` on by default

 Documenting rustc_parse v0.0.0 (/Users/runner/work/rust/rust/compiler/rustc_parse)
error: `rustc_infer` (lib doc) generated 1 warning
error: warnings are denied by `build.warnings` configuration
warning: build failed, waiting for other jobs to finish...
Command `/Users/runner/work/rust/rust/build/aarch64-apple-darwin/stage0/bin/cargo doc --target aarch64-apple-darwin -Zbinary-dep-depinfo -j 3 -Zroot-dir=/Users/runner/work/rust/rust -Zembed-metadata=no --locked --color=always --profile=release --features 'jemalloc llvm rustc' --manifest-path /Users/runner/work/rust/rust/compiler/rustc/Cargo.toml -Zskip-rustdoc-fingerprint --no-deps -Zrustdoc-map -p rustc-main -p rustc_abi -p rustc_arena -p rustc_ast -p rustc_ast_ir -p rustc_ast_lowering -p rustc_ast_passes -p rustc_ast_pretty -p rustc_attr_ir -p rustc_attr_parsing -p rustc_baked_icu_data -p rustc_borrowck -p rustc_builtin_macros -p rustc_codegen_llvm -p rustc_codegen_ssa -p rustc_const_eval -p rustc_crate_store -p rustc_data_structures -p rustc_driver -p rustc_driver_impl -p rustc_error_codes -p rustc_error_messages -p rustc_errors -p rustc_expand -p rustc_expand_queries -p rustc_feature -p rustc_fs_util -p rustc_graphviz -p rustc_hashes -p rustc_hir -p rustc_hir_analysis -p rustc_hir_id -p rustc_hir_pretty -p rustc_hir_typeck -p rustc_incremental -p rustc_index -p rustc_index_macros -p rustc_infer -p rustc_interface -p rustc_lexer -p rustc_lint -p rustc_lint_defs -p rustc_llvm -p rustc_log -p rustc_macros -p rustc_metadata -p rustc_middle -p rustc_mir_build -p rustc_mir_dataflow -p rustc_mir_transform -p rustc_monomorphize -p rustc_next_trait_solver -p rustc_parse -p rustc_parse_format -p rustc_passes -p rustc_pattern_analysis -p rustc_privacy -p rustc_proc_macro -p rustc_public -p rustc_public_bridge -p rustc_query_impl -p rustc_resolve -p rustc_sanitizers -p rustc_serialize -p rustc_session -p rustc_span -p rustc_structures -p rustc_symbol_mangling -p rustc_target -p rustc_thread_pool -p rustc_trait_selection -p rustc_traits -p rustc_transmute -p rustc_ty_utils -p rustc_ty_walk -p rustc_type_ir -p rustc_type_ir_macros -p rustc_windows_rc [workdir=/Users/runner/work/rust/rust]` failed with exit code 101
Created at: src/bootstrap/src/core/build_steps/doc.rs:946:25
Executed at: src/bootstrap/src/core/build_steps/doc.rs:1007:26

Command has failed. Rerun with -v to see more details.
Bootstrap failed while executing `--stage 2 test --host=aarch64-apple-darwin --target=aarch64-apple-darwin --skip tests --skip library --skip tidyselftest`
Currently active steps:
test::HtmlCheck { target: aarch64-apple-darwin } at src/bootstrap/src/core/build_steps/test.rs:260
doc::Rustc { build_compiler: Compiler { stage: 1, host: aarch64-apple-darwin, forced_compiler: false }, target: aarch64-apple-darwin, crates: ["rustc-main", "rustc_abi", "rustc_arena", "rustc_ast", "rustc_ast_ir", "rustc_ast_lowering", "rustc_ast_passes", "rustc_ast_pretty", "rustc_attr_ir", "rustc_attr_parsing", "rustc_baked_icu_data", "rustc_borrowck", "rustc_builtin_macros", "rustc_codegen_llvm", "rustc_codegen_ssa", "rustc_const_eval", "rustc_crate_store", "rustc_data_structures", "rustc_driver", "rustc_driver_impl", "rustc_error_codes", "rustc_error_messages", "rustc_errors", "rustc_expand", "rustc_expand_queries", "rustc_feature", "rustc_fs_util", "rustc_graphviz", "rustc_hashes", "rustc_hir", "rustc_hir_analysis", "rustc_hir_id", "rustc_hir_pretty", "rustc_hir_typeck", "rustc_incremental", "rustc_index", "rustc_index_macros", "rustc_infer", "rustc_interface", "rustc_lexer", "rustc_lint", "rustc_lint_defs", "rustc_llvm", "rustc_log", "rustc_macros", "rustc_metadata", "rustc_middle", "rustc_mir_build", "rustc_mir_dataflow", "rustc_mir_transform", "rustc_monomorphize", "rustc_next_trait_solver", "rustc_parse", "rustc_parse_format", "rustc_passes", "rustc_pattern_analysis", "rustc_privacy", "rustc_proc_macro", "rustc_public", "rustc_public_bridge", "rustc_query_impl", "rustc_resolve", "rustc_sanitizers", "rustc_serialize", "rustc_session", "rustc_span", "rustc_structures", "rustc_symbol_mangling", "rustc_target", "rustc_thread_pool", "rustc_trait_selection", "rustc_traits", "rustc_transmute", "rustc_ty_utils", "rustc_ty_walk", "rustc_type_ir", "rustc_type_ir_macros", "rustc_windows_rc"] } at src/bootstrap/src/core/build_steps/test.rs:273
Build completed unsuccessfully in 1:39:19

rust-bors · 2026-09-11T12:01:10Z

💔 Test for 6abe46e failed: CI. Failed job:

try - test-aarch64-apple-2 (web logs, enhanced plaintext logs)

rust-log-analyzer · 2026-09-11T13:36:32Z

The job test-pr-check-2 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

 Documenting rustc_infer v0.0.0 (/checkout/compiler/rustc_infer)
warning: unresolved link to `rustc_type_ir::deeply_resolve`
    --> compiler/rustc_infer/src/infer/mod.rs:1268:38
     |
1268 |     /// or better [`deeply_resolve`](rustc_type_ir::deeply_resolve), if you can, which *does* resolve regions.
     |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no item named `deeply_resolve` in module `rustc_type_ir`
     |
     = note: `#[warn(rustdoc::broken_intra_doc_links)]` on by default

 Documenting rustc_public_bridge v0.0.0 (/checkout/compiler/rustc_public_bridge)
 Documenting rustc_ty_walk v0.0.0 (/checkout/compiler/rustc_ty_walk)
 Documenting rustc_symbol_mangling v0.0.0 (/checkout/compiler/rustc_symbol_mangling)
error: `rustc_infer` (lib doc) generated 1 warning
error: warnings are denied by `build.warnings` configuration
warning: build failed, waiting for other jobs to finish...
Bootstrap failed while executing `doc compiler --stage 1`
Currently active steps:
doc::Rustc { build_compiler: Compiler { stage: 0, host: x86_64-unknown-linux-gnu, forced_compiler: false }, target: x86_64-unknown-linux-gnu, crates: ["rustc-main", "rustc_abi", "rustc_arena", "rustc_ast", "rustc_ast_ir", "rustc_ast_lowering", "rustc_ast_passes", "rustc_ast_pretty", "rustc_attr_ir", "rustc_attr_parsing", "rustc_baked_icu_data", "rustc_borrowck", "rustc_builtin_macros", "rustc_codegen_llvm", "rustc_codegen_ssa", "rustc_const_eval", "rustc_crate_store", "rustc_data_structures", "rustc_driver", "rustc_driver_impl", "rustc_error_codes", "rustc_error_messages", "rustc_errors", "rustc_expand", "rustc_expand_queries", "rustc_feature", "rustc_fs_util", "rustc_graphviz", "rustc_hashes", "rustc_hir", "rustc_hir_analysis", "rustc_hir_id", "rustc_hir_pretty", "rustc_hir_typeck", "rustc_incremental", "rustc_index", "rustc_index_macros", "rustc_infer", "rustc_interface", "rustc_lexer", "rustc_lint", "rustc_lint_defs", "rustc_llvm", "rustc_log", "rustc_macros", "rustc_metadata", "rustc_middle", "rustc_mir_build", "rustc_mir_dataflow", "rustc_mir_transform", "rustc_monomorphize", "rustc_next_trait_solver", "rustc_parse", "rustc_parse_format", "rustc_passes", "rustc_pattern_analysis", "rustc_privacy", "rustc_proc_macro", "rustc_public", "rustc_public_bridge", "rustc_query_impl", "rustc_resolve", "rustc_sanitizers", "rustc_serialize", "rustc_session", "rustc_span", "rustc_structures", "rustc_symbol_mangling", "rustc_target", "rustc_thread_pool", "rustc_trait_selection", "rustc_traits", "rustc_transmute", "rustc_ty_utils", "rustc_ty_walk", "rustc_type_ir", "rustc_type_ir_macros", "rustc_windows_rc"] } at src/bootstrap/src/core/build_steps/doc.rs:916
Command `/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo doc --target x86_64-unknown-linux-gnu -Zbinary-dep-depinfo -j 4 -Zroot-dir=/checkout -Zembed-metadata=no --locked --color=always --profile=release --features 'llvm rustc' --manifest-path /checkout/compiler/rustc/Cargo.toml -Zskip-rustdoc-fingerprint --no-deps -Zrustdoc-map -p rustc-main -p rustc_abi -p rustc_arena -p rustc_ast -p rustc_ast_ir -p rustc_ast_lowering -p rustc_ast_passes -p rustc_ast_pretty -p rustc_attr_ir -p rustc_attr_parsing -p rustc_baked_icu_data -p rustc_borrowck -p rustc_builtin_macros -p rustc_codegen_llvm -p rustc_codegen_ssa -p rustc_const_eval -p rustc_crate_store -p rustc_data_structures -p rustc_driver -p rustc_driver_impl -p rustc_error_codes -p rustc_error_messages -p rustc_errors -p rustc_expand -p rustc_expand_queries -p rustc_feature -p rustc_fs_util -p rustc_graphviz -p rustc_hashes -p rustc_hir -p rustc_hir_analysis -p rustc_hir_id -p rustc_hir_pretty -p rustc_hir_typeck -p rustc_incremental -p rustc_index -p rustc_index_macros -p rustc_infer -p rustc_interface -p rustc_lexer -p rustc_lint -p rustc_lint_defs -p rustc_llvm -p rustc_log -p rustc_macros -p rustc_metadata -p rustc_middle -p rustc_mir_build -p rustc_mir_dataflow -p rustc_mir_transform -p rustc_monomorphize -p rustc_next_trait_solver -p rustc_parse -p rustc_parse_format -p rustc_passes -p rustc_pattern_analysis -p rustc_privacy -p rustc_proc_macro -p rustc_public -p rustc_public_bridge -p rustc_query_impl -p rustc_resolve -p rustc_sanitizers -p rustc_serialize -p rustc_session -p rustc_span -p rustc_structures -p rustc_symbol_mangling -p rustc_target -p rustc_thread_pool -p rustc_trait_selection -p rustc_traits -p rustc_transmute -p rustc_ty_utils -p rustc_ty_walk -p rustc_type_ir -p rustc_type_ir_macros -p rustc_windows_rc [workdir=/checkout]` failed with exit code 101
Created at: src/bootstrap/src/core/build_steps/doc.rs:946:25
Executed at: src/bootstrap/src/core/build_steps/doc.rs:1007:26

Command has failed. Rerun with -v to see more details.
Build completed unsuccessfully in 0:03:17
  local time: Fri Sep 11 13:36:19 UTC 2026
  network time: Fri, 11 Sep 2026 13:36:19 GMT
##[error]Process completed with exit code 1.
##[group]Run echo "disk usage:"

obeis and others added 21 commits September 8, 2026 20:33

Use attribute parser for #[non_exhaustive] attribute check

5f0a64e

The fuchsia team maintains riscv64gc-unknown-fuchsia

a551126

split macroless_generic_const_args in two

15d0810

Skip linting unused braces for FunctionArg and MethodArg context for …

ad89677

…2024 edition

Fix target spec metadata for i686-pc-windows-msvc

c5eb55c

We no longer ship host tools for this target.

Update platform support page for windows-msvc

7125897

Update VS 2022 => VS 2026

04547c1

rename resolver folders and their access functions

ff820f4

rename opportunistic_resolve to shallow_resolve

2499f6f

better document various functions around resolve

b202d6f

make deeply_resolve a method on InferCtxtLike

670f799

rename fully_resolve to deeply_resolve_and_assert_fully_resolved

532134e

Rollup merge of rust-lang#161482 - obeis:check-non-exhaustive, r=Jona…

9176131

…thanBrouwer Use attribute parser for `#[non_exhaustive]` attribute check Updates rust-lang#153101 r? @JonathanBrouwer

Rollup merge of rust-lang#162549 - erickt:riscv64, r=JonathanBrouwer

cfe03fa

The fuchsia team maintains `riscv64gc-unknown-fuchsia` The fuchsia team maintains `riscv64gc-unknown-fuchsia` target (cc rust-lang#113739).

rust-bors Bot added the rollup A PR which is a rollup label Sep 11, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 11, 2026

This comment has been minimized.

Sign in to view

JonathanBrouwer closed this Sep 11, 2026

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 11, 2026

Navigation Menu

Uh oh!

Uh oh!

Rollup of 7 pull requests - #162627

Rollup of 7 pull requests#162627
JonathanBrouwer wants to merge 21 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-ie9aQjc

JonathanBrouwer commented Sep 11, 2026

Uh oh!

JonathanBrouwer commented Sep 11, 2026

Uh oh!

rust-bors Bot commented Sep 11, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Sep 11, 2026

Uh oh!

rust-log-analyzer commented Sep 11, 2026

Uh oh!

rust-bors Bot commented Sep 11, 2026

Uh oh!

rust-log-analyzer commented Sep 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Uh oh!

Uh oh!

Conversation

JonathanBrouwer commented Sep 11, 2026

Uh oh!

JonathanBrouwer commented Sep 11, 2026

Uh oh!

rust-bors Bot commented Sep 11, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Sep 11, 2026

Uh oh!

rust-log-analyzer commented Sep 11, 2026

Uh oh!

rust-bors Bot commented Sep 11, 2026

Uh oh!

rust-log-analyzer commented Sep 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants