Skip to content

Rollup of 21 pull requests - #161905

Closed
JonathanBrouwer wants to merge 54 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-HgmRlVv
Closed

Rollup of 21 pull requests#161905
JonathanBrouwer wants to merge 54 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-HgmRlVv

Conversation

@JonathanBrouwer

Copy link
Copy Markdown
Member

Successful merges:

Failed merges:

r? @ghost

Create a similar rollup

Kobzol and others added 30 commits June 30, 2026 12:43
…acting it

Co-authored-by: Marco Ieni <11428655+marcoieni@users.noreply.github.com>
... and related machienery
Remove trivial bounds

Panic on NaN

Make assert messages consistent with field names

Add clamp_to coretests

Update to fmt style

Use target_has_reliable_fN_math

Change existing clamp tests to use reliable_math

Use reliable_math on doctests too

Add #[expect] for NaN check
This is the normal behavior on other targets, but previously on wasm the
data segment would be in the default section and instead a custom
section with the given name would be added to the wasm module.
…, where the name is ambiguous, make to always

report the `ambiguous_glob_imported_traits` lint independent of the ordering of exports. Added a test to make sure both ordering trigger the lint.
This commit adds the `crt1-reactor.o` object file in the list of
pre-link-crt-objects for the `{Dynamic,Static}Dylib` output kinds for
WASI targets. These previously were omitted I believe by accident and
this means that the conventional `_initialize` function is not present
which runs constructor functions, for example. This is additionally
needed for the upcoming wasip3 target where this startup object file is
more load bearing than it was previously and will become required.
* Implement Reborrow as a recursive operation

If Reborrow finds '&'a mut T' fields then it inserts
a Deref and borrow of the T, and likewise if it finds a
'T: Reborrow' field then the field type is recursed into.

This makes Reborrow always produce the correct borrow checking logic at
the cost of most probably being inconsiderately expensive. The thinking
is that performance will be a followup consideration.
* PhantomDeref
* Simpler deref test

* Add more PhantomDeref unreachability assertions
* Write out lifetime omission
* Document ProjectionElem::PhantomDeref
* Comment half of reborrow tests
* fix PhantomDeref conflicting with AccessDepth::Shallow
* Recheck CoerceShared in borrowck TypeChecker to ensure its lifetimes make sense
* Fix rebase
* Changes... but where to?
* Typo fix

* Improve comment
* Use fully_perform_op to evaluate CoerceShared trait in borrowck
* More CoerceShared comment
* Comment rest of Reborrow tests

Co-authored-by: Oli Scherer <github35764891676564198441@oli-obk.de>
@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc O-unix Operating system: Unix-like S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Aug 28, 2026
@JonathanBrouwer

Copy link
Copy Markdown
Member Author

@bors r+ p=5

Trying commonly failed jobs
@bors try jobs=dist-various-1,test-various,x86_64-gnu-aux,x86_64-gnu-llvm-21-3,x86_64-msvc-1,aarch64-apple-1,aarch64-apple-2,x86_64-mingw-1,i686-msvc-1,i686-msvc-2

@rust-bors

rust-bors Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

📌 Commit ef67a60 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 28, 2026
@rust-bors

rust-bors Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

⌛ Trying commit ef67a60 with merge 134b5c4

To cancel the try build, run the command @bors try cancel.

Workflow: https://github.com/rust-lang/rust/actions/runs/33150335635

rust-bors Bot pushed a commit that referenced this pull request Aug 28, 2026
Rollup of 21 pull requests


try-job: dist-various-1
try-job: test-various
try-job: x86_64-gnu-aux
try-job: x86_64-gnu-llvm-21-3
try-job: x86_64-msvc-1
try-job: aarch64-apple-1
try-job: aarch64-apple-2
try-job: x86_64-mingw-1
try-job: i686-msvc-1
try-job: i686-msvc-2
@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Aug 28, 2026
…uwer

Rollup of 21 pull requests

Successful merges:

 - #158609 (Update sccache to 0.16.0)
 - #150075 (Implement clamp_to)
 - #159103 (fix(reborrow): recursive implementation)
 - #160562 (add target feature ABI checks for SPARC)
 - #160848 (std: avoid aliasing violations when wrapping opaque C types)
 - #161421 (Include startup crt objects on WASI for more outputs)
 - #161805 (Prefer ambiguous candidates when deduplicating traits in scope, so `ambiguous_glob_imported_traits` doesn't depend on import order)
 - #161862 (Put data segment in specified section with link_section on wasm)
 - #161866 (delegation: add tests fixating behavior of delegating to default trait implementations)
 - #161456 (reduce perf impact of scalar size checks)
 - #161528 (Add regression test to ensure optimal compilation)
 - #161666 (Print vendor instructions in `x vendor`)
 - #161730 (Improve type mismatch annotation for lets with block-wrapped initializers)
 - #161828 (Never type after-stabilization cleanup)
 - #161859 (Do not optimize MIR for comptime ConstFns)
 - #161860 (atomicptr.rs test: remove unused import)
 - #161870 (bind to [::1] instead of 127.0.0.1 in documentation examples for v6 UDP methods)
 - #161876 (rustdoc: Correctly handle when a macro generates multiple items in `--generate-macro-expansion`)
 - #161889 (Add link to ownership section in ptr::read docs)
 - #161890 (rustdoc: some clarifying comments)
 - #161891 (Mark `extern_item_impls` feature as incomplete)

Failed merges:

 - #161702 (Use `drop_guard` in some places in {core,alloc,std})
@rust-bors rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 28, 2026
@rust-bors

rust-bors Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

💔 Test for b7a36ac failed: CI. Failed job:

@rust-bors rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 28, 2026
@rust-bors

rust-bors Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

PR #158609, which is a member of this rollup, was unapproved.

@rust-log-analyzer

Copy link
Copy Markdown
Collaborator

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
#16 28.61 musl-1.2.5.tar.gz: OK
#16 28.61 mv sources/musl-1.2.5.tar.gz.tmp/musl-1.2.5.tar.gz sources/musl-1.2.5.tar.gz
#16 28.61 rm -rf sources/musl-1.2.5.tar.gz.tmp
#16 28.61 302 Moved Temporarily
#16 28.61 Location: https://ftp.eq.uc.pt/software/unix/gnu/gmp/gmp-6.3.0.tar.xz [following]
#16 28.61 --2026-08-28 08:01:15--  https://ftp.eq.uc.pt/software/unix/gnu/gmp/gmp-6.3.0.tar.xz
#16 28.61 Resolving ftp.eq.uc.pt (ftp.eq.uc.pt)... 193.137.214.36
#16 28.61 Connecting to ftp.eq.uc.pt (ftp.eq.uc.pt)|193.137.214.36|:443... connected.
#16 28.61 HTTP request sent, awaiting response... 200 OK
#16 28.61 Length: 2094196 (2.0M) [application/x-xz]
#16 28.61 Saving to: 'gmp-6.3.0.tar.xz'
#16 28.61 
#16 28.61      0K .......... .......... .......... .......... ..........  2%  319K 6s
---
#13 30.99 musl-1.2.5.tar.gz: OK
#13 30.99 mv sources/musl-1.2.5.tar.gz.tmp/musl-1.2.5.tar.gz sources/musl-1.2.5.tar.gz
#13 30.99 rm -rf sources/musl-1.2.5.tar.gz.tmp
#13 30.99 302 Moved Temporarily
#13 30.99 Location: https://ftp.fau.de/gnu/gcc/gcc-9.4.0/gcc-9.4.0.tar.xz [following]
#13 30.99 --2026-08-28 08:01:45--  https://ftp.fau.de/gnu/gcc/gcc-9.4.0/gcc-9.4.0.tar.xz
#13 30.99 Resolving ftp.fau.de (ftp.fau.de)... 131.188.12.211, 2001:638:a000:1021:21::1
#13 30.99 Connecting to ftp.fau.de (ftp.fau.de)|131.188.12.211|:443... connected.
#13 30.99 HTTP request sent, awaiting response... 200 OK
#13 30.99 Length: 72411232 (69M) [application/x-xz]
#13 30.99 Saving to: 'gcc-9.4.0.tar.xz'
#13 30.99 
#13 30.99      0K .......... .......... .......... .......... ..........  0%  254K 4m38s
---
#15 88.91 
#15 88.91 make: *** [Makefile:88: sources/gmp-6.3.0.tar.xz] Error 8
#15 88.91 make: *** Waiting for unfinished jobs....
#15 88.91 HTTP request sent, awaiting response... 302 Moved Temporarily
#15 88.91 Location: https://ftp.fau.de/gnu/binutils/binutils-2.44.tar.gz [following]
#15 88.91 --2026-08-28 08:02:23--  https://ftp.fau.de/gnu/binutils/binutils-2.44.tar.gz
#15 88.91 Resolving ftp.fau.de (ftp.fau.de)... 131.188.12.211, 2001:638:a000:1021:21::1
#15 88.91 Connecting to ftp.fau.de (ftp.fau.de)|131.188.12.211|:443... connected.
#15 88.91 HTTP request sent, awaiting response... 200 OK
#15 88.91 Length: 51342242 (49M) [application/x-gzip]
#15 88.91 Saving to: 'binutils-2.44.tar.gz'
#15 88.91 
#15 88.91      0K .......... .......... .......... ........302 Moved Temporarily
#15 88.91 Location: https://ftp.eq.uc.pt/software/unix/gnu/gcc/gcc-9.4.0/gcc-9.4.0.tar.xz [following]
#15 88.91 --2026-08-28 08:02:23--  https://ftp.eq.uc.pt/software/unix/gnu/gcc/gcc-9.4.0/gcc-9.4.0.tar.xz
#15 88.91 Resolving ftp.eq.uc.pt (ftp.eq.uc.pt)... .. ..........  0%  254K 3m17s
#15 88.91     50K .......... .......... .......... .......... ..........  0% 1.36M 1m56s
#15 88.91    100K .......... .......... .......... .......... ..........  0%  796K 98s
#15 88.91    150K .......... .......... .......... .......... ..........  0%  510K 98s
#15 88.91    200K .......... .......... .......... .......... ..........  0% 1.36M 86s
#15 88.91    250K .......... .......... .......... .......... ..........  0%  801K 82s
#15 88.91    300K .......... .......... .......... .......... ..........  0% 88.6M 70s
#15 88.91    350K .......... .......... .......... .......... ..........  0% 17.6M 62s
#15 88.91    400K ......193.137.214.36
#15 88.91 Connecting to ftp.eq.uc.pt (ftp.eq.uc.pt)|193.137.214.36|:443... .... .......... .......... .......... ..........  0%  523K 65s
#15 88.91    450K .......... .......... .......... .......... ..........  0%  145M 59s
#15 88.91    500K .......... .......... .......... .......... ..........  1% 17.9M 54s
#15 88.91    550K .......... .......... ........connected.
#15 88.91 .. .......... ..........  1%  526K 57s
#15 88.91    600K .......... .......... .......... .......... ..........  1%  103M 52s
---
#15 88.91  28900K ............. ..... .......... .......... .......... .......... 57%  241M 2s
#15 88.91  28950K .......... .......... .......... .......... .......... 57%  216M 2s
#15 88.91  29000K .......... .......... .......... .......... .......... 57%  249M 2s
#15 88.91  29050K .......... .......... .......... .......... .................. 58%  253M 2s
#15 88.91  29100K .......... .......... .......... ... ..................  .................... 58%  9%  187M 41.9M 2s 11s
#15 88.91  29150K
#15 88.91   6700K  ................... ........... .......... .......... .......... 58%  230M 1s
#15 88.91  29200K .......... .......... .......... .......... .......... 58%  222M 1s
#15 88.91  29250K .......... .......... .......... .......... .......... 58%  248M 1s
#15 88.91  29300K .......... .......... .......... .......... .......... 58%  255M 1s
---
#15 30.31 musl-1.2.5.tar.gz: OK
#15 30.31 mv sources/musl-1.2.5.tar.gz.tmp/musl-1.2.5.tar.gz sources/musl-1.2.5.tar.gz
#15 30.31 rm -rf sources/musl-1.2.5.tar.gz.tmp
#15 30.31 302 Moved Temporarily
#15 30.31 Location: https://ftp.man.poznan.pl/gnu/gmp/gmp-6.3.0.tar.xz [following]
#15 30.31 --2026-08-28 08:03:52--  https://ftp.man.poznan.pl/gnu/gmp/gmp-6.3.0.tar.xz
#15 30.31 Resolving ftp.man.poznan.pl (ftp.man.poznan.pl)... 150.254.173.17, 2001:808::173:17
#15 30.31 Connecting to ftp.man.poznan.pl (ftp.man.poznan.pl)|150.254.173.17|:443... connected.
#15 30.31 HTTP request sent, awaiting response... 200 OK
#15 30.31 Length: 2094196 (2.0M) [application/x-xz]
#15 30.31 Saving to: 'gmp-6.3.0.tar.xz'
#15 30.31 
#15 30.31      0K .......... .......... .......... .......... ..........  2%  489K 4s
---
#13 32.69 musl-1.2.5.tar.gz: OK
#13 32.69 mv sources/musl-1.2.5.tar.gz.tmp/musl-1.2.5.tar.gz sources/musl-1.2.5.tar.gz
#13 32.69 rm -rf sources/musl-1.2.5.tar.gz.tmp
#13 32.69 302 Moved Temporarily
#13 32.69 Location: https://ftp.eq.uc.pt/software/unix/gnu/gcc/gcc-9.4.0/gcc-9.4.0.tar.xz [following]
#13 32.69 --2026-08-28 08:04:28--  https://ftp.eq.uc.pt/software/unix/gnu/gcc/gcc-9.4.0/gcc-9.4.0.tar.xz
#13 32.69 Resolving ftp.eq.uc.pt (ftp.eq.uc.pt)... 193.137.214.36
#13 32.69 Connecting to ftp.eq.uc.pt (ftp.eq.uc.pt)|193.137.214.36|:443... connected.
#13 32.69 HTTP request sent, awaiting response... 200 OK
#13 32.69 Length: 72411232 (69M) [application/x-xz]
#13 32.69 Saving to: 'gcc-9.4.0.tar.xz'
#13 32.69 
#13 32.69      0K .......... .......... .......... .......... ..........  0%  322K 3m40s

@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Aug 28, 2026
@JonathanBrouwer

Copy link
Copy Markdown
Member Author

@bors try cancel

@rust-bors

rust-bors Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Try build cancelled. Cancelled workflows:

Hint: if you want to run another try build, you do not need to manually cancel the previous one. Just run @bors try and bors will cancel the previous build automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) A-CI Area: Our Github Actions CI A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc O-unix Operating system: Unix-like rollup A PR which is a rollup T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Development

Successfully merging this pull request may close these issues.