Rename extern "unadjusted" to extern "llvm-intrinsic" - #161398
Conversation
|
cc @tgross35 This PR changes rustc_public cc @oli-obk, @celinval, @ouz-a, @makai410
cc @rust-lang/miri
cc @Amanieu, @folkertdev, @sayantn |
|
r? @tgross35 rustbot has assigned @tgross35. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
515519e to
130b07c
Compare
This comment has been minimized.
This comment has been minimized.
130b07c to
e21f4cf
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
5b23cd8 to
c0dd7fd
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
c0dd7fd to
001d6e4
Compare
This makes it clear that it is only meant for LLVM intrinsics and not for defining or calling arbitrary user functions.
001d6e4 to
3f09e9e
Compare
|
CI passed. @tgross35 would you be able to take a look soon. This PR is fairly large, so it may be a bit bitrot prone. |
There was a problem hiding this comment.
LGTM from the standpoint of this just being a renaming, but we should make sure the regular stdarch maintainers are aware.
@folkertdev @adamgemmell @sayantn is stdarch reasonably up to date with r-l/r so this isn't going to cause conflicts with the next sync?
(r=me after one of them confirm)
@bors rollup=iffy p=5
|
Yes, this shouldn't cause any (large) issues @bors r=tgross35 |
|
Bors preserves iffy/never but doesn't preserve priority? @bors p=5 |
This comment has been minimized.
This comment has been minimized.
I think it interpreted the “p=5” as a note explaining ”rollup=iffy”, instead of as a separate directive. |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing e457a7b (parent) -> d0f2ef5 (this PR) Test differencesShow 8 test diffsStage 1
Stage 2
Additionally, 2 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard d0f2ef5e53039bd86fdcaa6e71860c4948880e04 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (d0f2ef5): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis perf run didn't have relevant results for this metric. Max RSS (memory usage)Results (primary 2.6%, secondary -4.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary -0.6%, secondary -3.6%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 476.343s -> 475.629s (-0.15%) |
This makes it clear that it is only meant for LLVM intrinsics and not for defining or calling arbitrary user functions.
Follow up to #160077