Consider `()` as suspicious only when expecting `!` for runtime symbols by Urgau · Pull Request #159513 · rust-lang/rust

Urgau · 2026-07-18T13:27:16Z

Consider () as suspicious only when expecting ! for runtime symbols, as ! is considered ABI compatible in Rust with () (#159446 (comment)).

Fixes #159446

rustbot · 2026-07-18T13:27:20Z

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 74 candidates
Random selection from 16 candidates

fee1-dead

r=me after

View changes since this review

Urgau · 2026-07-22T18:49:59Z

@bors r=fee1-dead

rust-bors · 2026-07-22T18:50:02Z

📌 Commit b1f030a has been approved by fee1-dead

It is now in the queue for this repository.

Urgau · 2026-07-22T18:50:11Z

@bors rollup

…e1-dead Consider `()` as suspicious only when expecting `!` for runtime symbols Consider `()` as suspicious only when expecting `!` for runtime symbols, as `!` is considered ABI compatible in Rust with `()` (rust-lang#159446 (comment)). Fixes rust-lang#159446

JonathanBrouwer · 2026-07-22T21:19:35Z

💔 I suspect this PR failed tests as part of a rollup
@bors r-

After fixing the problem, consider running a try job for the failed job before re-approving.

Link to failure: #159741 (comment)

rust-bors · 2026-07-22T21:19:42Z

This pull request was unapproved.

This PR was contained in a rollup (#159741), which was unapproved.

View changes since this unapproval

rustbot · 2026-07-22T21:43:54Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Urgau · 2026-07-22T21:47:26Z

Fixed a small conflict with the stabilization of c-variadics (#155697).

@bors r=fee1-dead

rust-bors · 2026-07-22T21:47:29Z

📌 Commit 970a689 has been approved by fee1-dead

It is now in the queue for this repository.

…e1-dead Consider `()` as suspicious only when expecting `!` for runtime symbols Consider `()` as suspicious only when expecting `!` for runtime symbols, as `!` is considered ABI compatible in Rust with `()` (rust-lang#159446 (comment)). Fixes rust-lang#159446

Rollup of 8 pull requests Successful merges: - #159504 (Abort const-eval queries early when there are generics in the type) - #159523 (std: fix Xous UDP recv length over-report and OOB panic) - #159605 (Add fallback for `intrinsics::fabs`) - #159699 (bump std libc to 0.2.189) - #159306 (Add new variant to iterating-updating-mutref borrowck test) - #159346 (fs::hard_link: use linkat on Android) - #159513 (Consider `()` as suspicious only when expecting `!` for runtime symbols) - #159734 (Document the link_section attribute)

Rollup merge of #159513 - Urgau:runtime-symbols-159446, r=fee1-dead Consider `()` as suspicious only when expecting `!` for runtime symbols Consider `()` as suspicious only when expecting `!` for runtime symbols, as `!` is considered ABI compatible in Rust with `()` (#159446 (comment)). Fixes #159446

Rollup of 8 pull requests Successful merges: - rust-lang/rust#159504 (Abort const-eval queries early when there are generics in the type) - rust-lang/rust#159523 (std: fix Xous UDP recv length over-report and OOB panic) - rust-lang/rust#159605 (Add fallback for `intrinsics::fabs`) - rust-lang/rust#159699 (bump std libc to 0.2.189) - rust-lang/rust#159306 (Add new variant to iterating-updating-mutref borrowck test) - rust-lang/rust#159346 (fs::hard_link: use linkat on Android) - rust-lang/rust#159513 (Consider `()` as suspicious only when expecting `!` for runtime symbols) - rust-lang/rust#159734 (Document the link_section attribute)

rustbot assigned fee1-dead Jul 18, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 18, 2026

Urgau mentioned this pull request Jul 18, 2026

Potential false positive for invalid_runtime_symbol_definitions lint #159446

Closed

fee1-dead requested changes Jul 22, 2026

View reviewed changes

Comment thread compiler/rustc_lint/src/runtime_symbols.rs Outdated

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 22, 2026

This comment has been minimized.

Sign in to view

Urgau force-pushed the runtime-symbols-159446 branch from ce1f705 to b1f030a Compare July 22, 2026 17:28

This comment has been minimized.

Sign in to view

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 22, 2026

JonathanBrouwer mentioned this pull request Jul 22, 2026

Rollup of 7 pull requests #159741

Closed

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 22, 2026

Consider () as suspicious only when expecting ! for runtime symbols

970a689

Urgau force-pushed the runtime-symbols-159446 branch from b1f030a to 970a689 Compare July 22, 2026 21:43

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 22, 2026

This was referenced Jul 22, 2026

Rollup of 9 pull requests #159747

Closed

Rollup of 8 pull requests #159748

Merged

rust-bors Bot merged commit 4739758 into rust-lang:main Jul 23, 2026
13 checks passed

rustbot added this to the 1.99.0 milestone Jul 23, 2026

lcnr added the relnotes Marks issues that should be documented in the release notes of the next release. label Jul 31, 2026

rustbot mentioned this pull request Jul 31, 2026

Tracking issue for release notes of #159513: Consider () as suspicious only when expecting ! for runtime symbols #160265

Closed

Urgau removed the relnotes Marks issues that should be documented in the release notes of the next release. label Jul 31, 2026

Uh oh!

Uh oh!

Conversation

Urgau commented Jul 18, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jul 18, 2026

Uh oh!

fee1-dead left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

Urgau commented Jul 22, 2026

Uh oh!

rust-bors Bot commented Jul 22, 2026

Uh oh!

Urgau commented Jul 22, 2026

Uh oh!

JonathanBrouwer commented Jul 22, 2026

Uh oh!

rust-bors Bot commented Jul 22, 2026

Uh oh!

rustbot commented Jul 22, 2026

Uh oh!

Urgau commented Jul 22, 2026

Uh oh!

rust-bors Bot commented Jul 22, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Urgau commented Jul 18, 2026 •

edited by rustbot

Loading

fee1-dead left a comment •

edited by rustbot

Loading