fix: don't panic on doc comments attached to literal expressions - #23295
Open
Aditya-PS-05 wants to merge 1 commit into
Open
fix: don't panic on doc comments attached to literal expressions#23295Aditya-PS-05 wants to merge 1 commit into
Aditya-PS-05 wants to merge 1 commit into
Conversation
rustbot
added
the
S-waiting-on-review
bit-aloo
reviewed
Sep 5, 2026
Member
There was a problem hiding this comment.
Thanks! Can you also check for other places where we filter things based on whether they are trivia? I am pretty sure this change could have subtle effects elsewhere too, since DOC_COMMENT recently moved to its own node and is no longer considered trivia.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #23293
issue was that doc comments trivia changed to DOC_COMMENT nodes (in 143c033).
Literal::token()skips only for ATTR and trivia and so panics for DOC_COMMENT (as it's 3rd new type) and so fixed it by checking it.