fix wrong quick fix for marco call - #23252
Open
Young-Flash wants to merge 4 commits into
Open
Conversation
rustbot
added
the
S-waiting-on-review
A4-Tacks
reviewed
Aug 29, 2026
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
A4-Tacks
approved these changes
Aug 30, 2026
ChayimFriedman2
requested changes
Sep 1, 2026
| expr_ptr: &InFile<AstPtr<ast::Expr>>, | ||
| acc: &mut Vec<Assist>, | ||
| ) -> Option<()> { | ||
| let range = ctx.sema.diagnostics_display_range((*expr_ptr).map(|it| it.into())); |
Contributor
There was a problem hiding this comment.
We indeed should not remove diagnostics_display_range() and use other method. Why did you do that?
Contributor
There was a problem hiding this comment.
The difference is that diagnostics_display_range() uses rooted mappings, meaning it won't show inside macros.
Young-Flash
force-pushed
the
wrong-quick-fix-for-marco-call
branch
from
September 5, 2026 02:56
80ba595 to
61d0ce5
Compare
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #19428 & #23247