avoid explicit .filler section - #217
Open
robamu wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
oh, forgot something really important when copy-and-pasting this from a z7link.x . the STACKS section now needs an explicit address |
Contributor
|
@umohr-irs wrote that code in #93, IIRC |
robamu
force-pushed
the
no-explicit-filler-section
branch
from
August 28, 2026 16:53
366d5c0 to
3dd47c0
Compare
robamu
marked this pull request as ready for review
August 28, 2026 16:53
Contributor
Author
|
maybe the |
Contributor
Author
|
No, i tested a bit, and i get overlap errors when .stacks overlaps with .bss |
Contributor
|
Looks OK to me. Did some test builds and the stacks were where I expected them to be. |
jonathanpallant
approved these changes
Aug 31, 2026
jonathanpallant
added this pull request to the merge queue
Aug 31, 2026
jonathanpallant
removed this pull request from the merge queue due to a manual request
Aug 31, 2026
Contributor
|
Whoops - @robamu can you add a CHANGELOG entry? "Replaced .filler padding section with fixed offset for stack placement in |
- The .filler section would count to the .bss segment for tools like llvm-size which lead to bloated/wrong .bss segment information.
robamu
force-pushed
the
no-explicit-filler-section
branch
from
August 31, 2026 21:41
8d5a6cb to
ee70de5
Compare
jonathanpallant
added this pull request to the merge queue
Sep 1, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Sep 1, 2026
jonathanpallant
added this pull request to the merge queue
Sep 1, 2026
jonathanpallant
removed this pull request from the merge queue due to a manual request
Sep 1, 2026
Contributor
|
I'm hoping merging #222 will stop the queue being so unreliable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When placing the filler into the STACK region, it counts towards .bss when displaying it with tools like llvm-size. no idea why. when we calculate the start of stacks without a dedicated filler segment, i don't have that issue. however, i still want to do some tests because maybe there was a reason this was done with an explicit section?