Skip to content

docs: fix stale corepc-node references#574

Open
satsfy wants to merge 2 commits intorust-bitcoin:masterfrom
satsfy:fix-bitcoind-related-idioms
Open

docs: fix stale corepc-node references#574
satsfy wants to merge 2 commits intorust-bitcoin:masterfrom
satsfy:fix-bitcoind-related-idioms

Conversation

@satsfy
Copy link
Copy Markdown
Contributor

@satsfy satsfy commented May 1, 2026

Follow up from #573 (comment)

Continues corepc-node to bitcoind rename.

This updates stale documentation references that were missed in earlier changes. It fixes the top level crate listing, the bitcoind crate README examples and text, the bitcoind/contrib/extra_tests.sh comments, and the integration_test README.

@tcharding
Copy link
Copy Markdown
Member

Oh extra_test.sh is from the old CI setup, it can be deleted. As can crates.sh.

update-lock-files.sh can go too if the justfile is patched as well but that is kind of unrelated.

@tcharding
Copy link
Copy Markdown
Member

I think that is the second time this week I've seen that CI fail. Re-ran it.

Copy link
Copy Markdown
Collaborator

@jamillambert jamillambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have created the label C-bitcoind that the changes in this PR require.

All the docs changes look good. The deletion of extra_tests.sh, crates.sh and update-lock-files.sh and updating the justfile can be done here or a separate PR.

Reviewed a5e8d9b

@satsfy
Copy link
Copy Markdown
Contributor Author

satsfy commented May 1, 2026

Thanks, looked more sensible to open a new PR for it #575

Copy link
Copy Markdown
Collaborator

@jamillambert jamillambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you swap the commit order, currently you "fix" extra_tests.sh then in the next commit delete it.

@satsfy satsfy force-pushed the fix-bitcoind-related-idioms branch from e975e37 to 7c3ed79 Compare May 1, 2026 21:05
@satsfy
Copy link
Copy Markdown
Contributor Author

satsfy commented May 1, 2026

Force push with the mentioned change, my oversight, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants