Fix infinite loop in define_all for RBS include with same-name nested constant#437
Merged
mame merged 1 commit intoruby:masterfrom Apr 16, 2026
Merged
Conversation
…ed constant When `module X` contains `class X`, resolving `include X` in RBS searched the ancestor chain (`search_ancestors=true`), which caused the resolved constant to flip between X (module) and X::X (class) on every re-evaluation, looping `define_all` forever. The .rb side already avoids this via `use_strict_const_scope` in IncludeMetaNode. Apply the same `strict_const_scope=true` to SigIncludeNode and SigPrependNode so that include/prepend targets are resolved through lexical scope only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
module Xcontainsclass X, resolvinginclude Xin RBSsearched the ancestor chain (
search_ancestors=true), which caused theresolved constant to flip between X (module) and X::X (class) on
every re-evaluation, looping
define_allforever.The .rb side already avoids this via
use_strict_const_scopeinIncludeMetaNode. Apply the same
strict_const_scope=truetoSigIncludeNode and SigPrependNode so that include/prepend targets
are resolved through lexical scope only.
fixes #431