Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative solution to the issue described in #904 and #905.
The problem statement is that when use aws codebuild as self-hosted runner, the
$GITHUB_WORKSPACEwould change on every single build, and currently the cache key containsprocess.cwd(), thus it will always invalidate the cache.The solution in this PR is to use a relative cwd computed from
$GITHUB_WORKSPACEinstead of the absolute cwd, so that it works consistently on github runner and other runners.Note: This change will break all caches on all repositories once when updating to this version due to updating the cache key, but after that cache should work again.