Repository navigation
Run the kit on Windows as well as macOS and Linux - #1
Merged
Merged
Conversation
On Windows the kit stopped before any test ran: npx, npm and an npm-installed claude are .cmd shims, which Node can't spawn without a shell. kit/run.ts now quotes the kit's own arguments into one cmd.exe command line there, refusing anything cmd.exe could still expand, and calls the command directly elsewhere. Agent prompts go in on stdin, so free text never reaches a command line. Other Windows breaks fixed on the way: - Test paths from listTests() use forward slashes. Playwright reads file filters as regular expressions, so e2e\specs became \s and the mutation runner selected nothing. - Mutation find/replace strings match CRLF files and CRLF function sources. - snapshot.ts's entry check compares file URLs, not file:// plus a path. - .gitattributes keeps checkouts LF, so format:check passes on Windows. Errors from npx calls now say why they failed, e.g. the Supabase CLI's own message instead of always "Local Supabase is not running". CI runs the unit tests, the suite, coverage and the mutation runner on Windows and macOS too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On Windows the kit stopped before any test ran.
npx,npmand an npm-installedclaudeare.cmdshims, and Node can't spawn those without a shell (ENOENT, or EINVAL since the CVE-2024-27980 fix). Errors from Supabase key lookup were swallowed into "Local Supabase is not running", even with the stack up.Change
kit/run.ts:run()/npx()/failure(). On Windows it quotes the kit's own arguments into onecmd.execommand line and refuses anythingcmd.execould still expand (",%,!,^, newlines). Elsewhere it calls the command directly, as before. Everynpxcall site, Claude detection and the demo capture script use it.claude -preads it), so free text never touches a command line on any platform.listTests(): Playwright reads file filters as regexes, soe2e\specs\…turned into\sand the mutation runner selected nothing on Windows.kit/eol.ts): find/replace strings match CRLF files and function sources created from CRLF migrations.snapshot.tsentry check compares file URLs;.gitattributeskeeps checkouts LF soformat:checkpasses on Windows.Tests (windows-latest / macos-latest)job runs typecheck, unit tests, the suite, coverage and the mutation runner.Verified on macOS
npm run check(31 unit tests),npm test48 passed,npm run coverage -- --strict19/19,npm run mutate12/12 caught,requireClaudethrough the new runner,node kit/heal/snapshot.ts. Windows is covered by the new CI job.