Skip to content

Stack basecamp #322, #325, #323, #324, #316 onto preview - #2

Merged
thomasklemm merged 6 commits into
previewfrom
cursor/preview-perf-prs-8545
Oct 5, 2026
Merged

thomasklemm merged 6 commits into
previewfrom
cursor/preview-perf-prs-8545

Conversation

@thomasklemm

@thomasklemm thomasklemm commented Oct 5, 2026 •

Copy link
Copy Markdown

preview stacks submitted-but-unmerged upstream PRs. This adds the next performance / fewer-queries batch.

Order

  1. Cache boosts with their message instead of one by one basecamp/once-campfire#322 — cache boosts with their message (APPROVED)
  2. Render the boosts a message has preloaded instead of querying them again basecamp/once-campfire#325 — render preloaded boosts instead of querying again (APPROVED; builds on Cache boosts with their message instead of one by one basecamp/once-campfire#322)
  3. Count unread rooms for push badges once per batch basecamp/once-campfire#323 — count unread rooms for push badges once per batch (APPROVED)
  4. Rewrite a message's search entry only when its body or attachment changes basecamp/once-campfire#324 — rewrite search index only when body/attachment changes
  5. List one page of account members at a time basecamp/once-campfire#316 — list one page of account members at a time

Fix on this branch

Upstream basecamp#316 still used <%= "checked" %> on the account settings switch. That fails Roundhouse's bin/rails herb:check. Restored preview's tag.input … checked: form.

Held back

basecamp#326 (reuse pinned push connections) — overlaps lib/web_push/pool.rb with basecamp#323 and still has open review threads.

Already elsewhere

… one

From namespaceMarcello (upstream PR state at merge: OPEN).
… of querying them again

From namespaceMarcello (upstream PR state at merge: OPEN).
From namespaceMarcello (upstream PR state at merge: OPEN).
…dy or attachment changes

From namespaceMarcello (upstream PR state at merge: OPEN).
From namespaceMarcello (upstream PR state at merge: OPEN).
preview already renders the restrict-room-creation switch through
tag.input. Upstream basecamp#316 still used <%= "checked" %>, which fails
bin/rails herb:check.
@thomasklemm
thomasklemm merged commit 642fc45 into preview Oct 5, 2026
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant