Repository navigation
Stack basecamp #322, #325, #323, #324, #316 onto preview - #2
Merged
Merged
Conversation
… one From namespaceMarcello (upstream PR state at merge: OPEN).
… of querying them again From namespaceMarcello (upstream PR state at merge: OPEN).
From namespaceMarcello (upstream PR state at merge: OPEN).
…dy or attachment changes From namespaceMarcello (upstream PR state at merge: OPEN).
From namespaceMarcello (upstream PR state at merge: OPEN).
preview already renders the restrict-room-creation switch through tag.input. Upstream basecamp#316 still used <%= "checked" %>, which fails bin/rails herb:check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
previewstacks submitted-but-unmerged upstream PRs. This adds the next performance / fewer-queries batch.Order
Fix on this branch
Upstream basecamp#316 still used
<%= "checked" %>on the account settings switch. That fails Roundhouse'sbin/rails herb:check. Restored preview'stag.input … checked:form.Held back
basecamp#326 (reuse pinned push connections) — overlaps
lib/web_push/pool.rbwith basecamp#323 and still has open review threads.Already elsewhere