Repository navigation
[Datadog] Fix Static Code Analysis violation - #8
Merged
Merged
Conversation
Co-authored-by: datadog-romeo-rosete[bot] <321584152+datadog-romeo-rosete[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The quoted substitution combines separate flags and values into one argument, breaking compatibility verification.
Review effort: Balanced
Findings: 1
What changed in this PR
This PR addresses a Datadog static-analysis warning in the compatibility runner.
Changes:
- Quotes the command substitution that reads arguments for
op-program.
| File | Description |
|---|---|
op-program/scripts/run-compat.sh |
Quotes the contents of args.txt when invoking the program. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request was automatically created by Datadog to fix this vulnerability.
It introduces a remediation for the AST vulnerability detected by rule
bash-security/double-quote-command-substitutions.This change is intended to address the issue identified. Please review the suggested update before merging.