Skip to content

Support iterable ROS arguments in Node - #557

Open
Old-Ding wants to merge 1 commit into
ros2:rollingfrom
Old-Ding:codex/support-node-ros-argument-iterables
Open

Support iterable ROS arguments in Node#557
Old-Ding wants to merge 1 commit into
ros2:rollingfrom
Old-Ding:codex/support-node-ros-argument-iterables

Conversation

@Old-Ding

Copy link
Copy Markdown

Summary

  • materialize Node.ros_arguments at the command construction boundary
  • support generators, iterators, tuples, and other finite iterables promised by the public annotation
  • run the existing ROS argument launch test with an iterator

Testing

  • focused expression probe: baseline list concatenation raises TypeError for an iterator, while the fixed expression preserves argument order
  • python -m py_compile for both modified Python files
  • flake8 on both modified files with the repository's existing E501/W504 exclusions
  • git diff --check

Node declares ros_arguments as an Iterable, but list concatenation rejected tuples, generators, and iterators. Materialize the iterable at the command construction boundary and exercise the existing launch test with an iterator.

Signed-off-by: Old-Ding <35417409+Old-Ding@users.noreply.github.com>
@mergify

mergify Bot commented Jul 11, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant