Repository navigation
Fix quadratic backtracking over malformed strings in check_struct_type - #639
Merged
juntyr merged 2 commits intoOct 24, 2026
Merged
Conversation
juntyr
reviewed
Oct 23, 2026
juntyr
reviewed
Oct 23, 2026
Member
|
Thanks @danish293! Once you address my comments, I will merge your PR :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quadratic rescan of malformed strings in
check_struct_typeThe newtype/tuple lookahead only gave up on
ExpectedStringEnd/Eof, so a string ending in a bad escape, likeA("\"\"\"...\q")deserialised into an untagged enum, was re-parsed from every escaped". 80 KB of input took 33 s in a release build (16 s forb"...", 7.9 s through#![enable(unwrap_variant_newtypes)], which the document can turn on itself). Now onlyExpectedString/ExpectedByteString(not a string here) backtrack, which brings that input to 0.4 ms and reports the actualInvalidEscape.CHANGELOG.md