Repository navigation
Add from_value convenience function - #618
Open
ChrisJr404 wants to merge 1 commit into
Open
ChrisJr404 wants to merge 1 commit into
ChrisJr404 wants to merge 1 commit into
Conversation
juntyr
reviewed
Aug 25, 2026
|
|
||
| - Add support for parsing Rust-style string continuation escapes ([#585](https://github.com/ron-rs/ron/issues/585)) | ||
|
|
||
| ### Additions |
Member
There was a problem hiding this comment.
Suggested change
| ### Additions | |
| ### API Changes |
|
|
||
| ### Additions | ||
|
|
||
| - Add the `from_value` convenience function to deserialize a `T` from a `Value` ([#255](https://github.com/ron-rs/ron/issues/255)) |
Member
There was a problem hiding this comment.
Could you please link to this PR instead, and also drive-by fix the above change log entry to also link to its PR?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As suggested in #255, this adds
from_valueto thedemodule so aValuecan be deserialized into aTwith the same convenience asfrom_str/from_bytes/from_reader.It just wraps the existing
Value::into_rust, so there's no new logic. It returns a plainErrorinstead of aSpannedError, since an in-memoryValuehas no source text to point a span into.to_valueand the widerValueconversion work mentioned in #255 are left out on purpose, since those were flagged for the 0.9 round.CHANGELOG.md