Skip to content

Technical debt #640

Description

@zbynekwinkler

Please add all stuff we say "let's merge now anyway, fix it later".

Activity

  1. zbynekwinkler commented on Sep 27, 2020

    @zbynekwinkler
    MemberAuthor

    #636 (comment) osgar/drivers/lora.py

  2. zbynekwinkler commented on Sep 27, 2020

    @zbynekwinkler
    MemberAuthor

    #636 (comment) move ArtifactsReporter away from subt/artifacts.py file.

  3. zbynekwinkler commented on Sep 28, 2020

    @zbynekwinkler
    MemberAuthor

    #639 (comment) delete confusing comment in cloudsim2osgar

  4. zbynekwinkler commented on Sep 28, 2020

    @zbynekwinkler
    MemberAuthor
  5. zbynekwinkler commented on Oct 1, 2020

    @zbynekwinkler
    MemberAuthor

    #644 (comment) refactor osgar.Node and all different SomethingHandler classes in bus.py (when one is updated/changed, all of them need to be changed).

  6. zbynekwinkler commented on Oct 6, 2020

    @zbynekwinkler
    MemberAuthor

    #657 (comment) refactor CommsClient out from ros_proxy_node and move the rest of it to cloudsim2osgar.py. CommsClient sends and receives bytes so said bytes can contain msgpack encoded data from osgar and only osgar needs to be able to parse them (not the c++ CommsClient).

  7. zbynekwinkler commented on Oct 6, 2020

    @zbynekwinkler
    MemberAuthor

    Follow left wall should not follow wall on the right and vice versa. Currently it finds the closest wall and then turns with its left or right side to it. We had a nice counter example in system urban where mobos was running in circles due to this.

  8. zbynekwinkler commented on Oct 7, 2020

    @zbynekwinkler
    MemberAuthor

    Run validator automatically on each and every cloudsim run (run it on some server, autodownload logs, generate some html report, email it, publish it to a website).

  9. zbynekwinkler commented on Oct 7, 2020

    @zbynekwinkler
    MemberAuthor

    Create our own cloudsim somewhere - need at least 5 computers to be worth it (1 with nvidia gpu for simulation, 4 for robots - no gpu needed if we switch from pytorch to opencv). The computers don't have to be super fast - we could limit RTF on the simulation side. The simulation is effectively able to use only 4 cores + GPU with 4GB. If the robots won't need GPU, a 4 cores might be enough. So about 20 cpu cores and one nvidia gpu.

  10. zbynekwinkler commented on Oct 8, 2020

    @zbynekwinkler
    MemberAuthor
  11. zbynekwinkler commented on Oct 10, 2020

    @zbynekwinkler
    MemberAuthor

    #667 (comment) in zmqrouter log all uncaught exceptions in child processes

  12. jisa commented on Oct 10, 2020

    @jisa
    Collaborator

    We don't need to switch from pytorch to opencv to avoid running on GPU. All it takes is to say we want to run on cpu:

    device = torch.device("cuda" if use_cuda else "cpu")

    Or simply to not have the gpu, in which case it will switch to cpu automatically.

  13. m3d commented on Oct 10, 2020

    @m3d
    Member

    Cleanup zmq-subt-x4.json - it contains "mines" like

    ["rosmsg.orientation", "app.orientation"]
    

    which is now working, because subt/main.py is using self.orientation from pose3d.

  14. zbynekwinkler commented on Oct 12, 2020

    @zbynekwinkler
    MemberAuthor

    Running two DNN detectors in sequence is not ideal for a local development. I am getting so much delay errors that the console is unusable.

    Also the opencv dnn running on CPU seems to be allocating nontrivial amount of threads that compete over the cpu cores with everything else. That leads to unpredictable runtime behavior - the other CPU cores are for other modules and not for greedy opencv. Having such a behavior also complicates planning for our own cloudsim and its hw needs.

  15. zbynekwinkler commented on Oct 13, 2020

    @zbynekwinkler
    MemberAuthor

    #667 (comment) in zmqrouter log all uncaught exceptions in child processes

    I thought that when a node crashes, the whole thing is taken down, but that is not true. The crash goes unnoticed. The only time the whole thing stops is when any of the nodes stops regularly. For example exception thrown from the __init__ goes totally unnoticed (except message to the console, which on cloudsim means /dev/null).

  16. zbynekwinkler commented on Oct 15, 2020

    @zbynekwinkler
    MemberAuthor

    #693 (comment) we should introduce something like --draw profile or --draw delay ... i.e. optional --draw extra parameter (there are other modules where I am also commenting out graphs of different variables).

  17. zbynekwinkler commented on Oct 15, 2020

    @zbynekwinkler
    MemberAuthor

    Follow left wall should not follow wall on the right and vice versa. Currently it finds the closest wall and then turns with its left or right side to it. We had a nice counter example in system urban where mobos was running in circles due to this.

    Like here: robotika/subt-artf#55 (comment)

  18. zbynekwinkler commented on Oct 15, 2020

    @zbynekwinkler
    MemberAuthor

    Add unittest to subt.drone setting height: #702 (review)

  19. jisa commented on Oct 16, 2020

    @jisa
    Collaborator

    Add capability to report multiple artifacts from a single image. Our detectors can handle multiple objects of interest in the same scene, our reporting cannot.

  20. zbynekwinkler commented on Oct 23, 2020

    @zbynekwinkler
    MemberAuthor

    Wait until ROS starts up #713 (comment)

  21. m3d commented on Nov 9, 2020

    @m3d
    Member

    System Track robots do not have working artefact detector - change from 2D answer to extended info with 3D relative position. See #735

  22. zbynekwinkler commented on Nov 9, 2020

    @zbynekwinkler
    MemberAuthor

    I think we should figure out a way how to use the information provided by the service returning the robot offset from the artifact origin for limiting from where artifact may be submitter, thus not reporting artifacts while we get the offset. That would remove the need for the constants defining the staging area. #738 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions