Add tool to generate video subtitles - #37
Merged
Merged
Conversation
m3d
requested review from
GeorgiSGeorgiev,
Jaroslav-Krch,
MartinLocker and
tajgr
August 7, 2026 18:52
note, that it is expected to fail because I do not plan to add real data into git yet
m3d
commented
Aug 24, 2026
m3d
commented
Aug 24, 2026
m3d
commented
Aug 24, 2026
m3d
commented
Aug 24, 2026
m3d
commented
Aug 24, 2026
m3d
commented
Aug 24, 2026
| if log_end_time == 0.0: | ||
| log_end_time = last_dt.total_seconds() | ||
|
|
||
| # If the last event timestamp is greater than log_end_time, adjust log_end_time |
Member
Author
There was a problem hiding this comment.
what?! or is it after offset correction?
m3d
commented
Aug 24, 2026
|
|
||
| try: | ||
| process_log_to_subtitles(args.logfile, args.output_srt, args.offset) | ||
| except Exception as e: |
Member
Author
There was a problem hiding this comment.
why this try/except? Only the trace will be lost :(
m3d
commented
Aug 24, 2026
m3d
commented
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI generated (to be reviewed) code for "machine status subtitles" ... original motivation of multi-log (robotika/osgar#1083) ... as platform is Pat, but video is from Matty M03
Edit: I forgot to add link to the example video with subtitles :)
https://www.youtube.com/watch?v=mkee_2f4eGo