feat: add google auth login - #662
Open
MickaelCa wants to merge 2 commits into
Open
Conversation
MickaelCa
marked this pull request as ready for review
September 8, 2023 17:29
MickaelCa
force-pushed
the
feat/add-google-auth
branch
from
January 10, 2024 09:18
9ab5208 to
100853f
Compare
Author
|
PR rebased for conflicts |
MickaelCa
force-pushed
the
feat/add-google-auth
branch
from
March 11, 2024 00:21
100853f to
f05789f
Compare
Author
|
any chance to see this merged ? |
|
@sztwiorok any chance to review this PR? |
Contributor
|
@MickaelCa @TheoAlloin We will review and merge it in a week |
Contributor
|
we checked the code and everything is fine. @MickaelCa could you make some small change in the code to run the GHA tests again? |
MickaelCa
force-pushed
the
feat/add-google-auth
branch
from
October 10, 2024 07:37
f05789f to
6959927
Compare
Author
|
@sztwiorok I rebased on main and force-pushed, should be enough! |
Contributor
|
@MickaelCa thanks |
Contributor
|
@MickaelCa, there are problems with unit tests, could you look at this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we use Google SSO so I added it