perf(ui): Use indicative quotes for dead addresses - #1130
Conversation
Co-authored-by: Pedro Cunha <6723339+pedromcunha@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Claude finished @pedromcunha's task in 51s —— View job Code Review
Code Review — No issues found. Reviewed 2 files, 14 lines changed. Checked for correctness, security, error handling, and repo guidelines compliance. What I verified:
|
|
Claude finished @pedromcunha's task in 26s —— View job 📝 Docs Drift Check — No docs impact This PR does not touch surfaces that require a |
|
Indicative quotes return an empty steps array with the id only at the top level, so extractQuoteId fell back to undefined for QUOTE_RECEIVED and the swap analytics events. Thread the response requestId through as a fallback. Gate indicative quotes on the widget's own address validity rather than on isDeadAddress of the resolved address, so a user who deliberately enters a burn address still gets an executable quote, and guard swap() against a quote with no steps (executeSteps treats an empty step list as complete). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2059991
|
Claude finished @pedromcunha's task in 1m 7s —— View job Code Review
Code Review — No issues found. Reviewed 4 files, 41 lines changed. Checked for correctness, security, error handling, and repo guidelines compliance. What I verified:
No correctness, security, or error-handling concerns found. The two commits together keep both the executability guard and the analytics |
|
Claude finished @pedromcunha's task in 39s —— View job 📝 Docs Drift Check — No docs impact This PR does not touch surfaces that require a |
A burn address passes syntax validation, so a user-entered one counted as a valid recipient: the widget requested an executable quote and ran swap(), while the API silently rewrites a burn recipient, so the SDK's dead-address guard never fired. Exclude burn addresses from the from/to validity checks and from addressWithFallback, so they consistently collapse to the per-chain placeholder and yield a preview-only quote that cannot be executed. Stop the address modal from resolving one, and drop stale burn addresses from recents. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Claude finished @pedromcunha's task in 39s —— View job 📝 Docs Drift Check — No docs impact This PR does not touch surfaces that require a |
|
Claude finished @pedromcunha's task in 1m 3s —— View job Code Review
Code Review — No issues found. Reviewed 6 files, ~75 lines changed. Checked for correctness, security, error handling, and repo guidelines compliance. Note on the earlier Greptile P1 ("Dead addresses remain executable"): that finding was raised against commit What I verified:
No correctness, security, or error-handling concerns found. |
The Swap Widget now requests an indicative quote when its sender or recipient uses a dead-address placeholder. This reduces executable quote work while a wallet or recipient is missing.
Deposit-address flows remain executable because the quote API does not allow
indicativeQuotewithuseDepositAddress.When valid addresses become available, the query parameters change and the widget requests a normal executable quote.
This also adds a patch changeset for
@relayprotocol/relay-kit-ui.Action taken on behalf of Pedro Cunha.
Checks:
git diff --checkRequested by Pedro Cunha.
--
View Junior Session [Sentry]