docs: chat app recipe with streaming patterns#6788
Conversation
Merging this PR will not alter performance
Comparing Footnotes
|
Greptile SummaryThis PR adds a new "Chat App" recipe under
Confidence Score: 5/5Safe to merge — two documentation files with no runtime code paths in the main application. The changes are purely additive documentation. The correct streaming example is well-constructed: all state vars are declared, mutations stay inside async with self: blocks, the stream is wrapped in try/finally, and the is_generating guard with captured index prevents overlapping-stream races. Every issue raised in prior review rounds has been addressed. No files require special attention. Important Files Changed
Reviews (6): Last reviewed commit: "Update docs/recipes/others/chat.md" | Re-trigger Greptile |
…nai, try/finally is_streaming)
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 722007582a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Addressed in the latest commit ("Keep streamed tokens tied to their own assistant message"), taking the second remedy you suggested (per-turn index rather than The streaming handler now captures the assistant bubble's index when it's first appended ( On the loading flag: I traced the state mutations rather than driving a live token stream (the example uses a placeholder LLM client). |
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Adds a chat-app recipe under
docs/recipes/others/: a basic message-bubble chat UI plus the streaming-append patterns (append the assistant message on the first token, not before) that keep the loading experience clean.Draft — from the AI-builder memory corpus. Draft pending a news fragment /
skip-changeloglabel and a sidebar/recipe-index entry if needed.🤖 Generated with Claude Code