kafka: create the consumer offsets topic as a local topic - #31576
Open
andrwng wants to merge 1 commit into
Open
Conversation
The offsets topic has pretty much been local in all but name: it explicitly doesn't construct an archiver, and the local storage layer explicitly prevents truncating it. It's never relied on tiered storage for disaster recovery since that is handled through separate snapshotting code. This commit makes this explicit, creating the topic as an explicit local topic.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes the Kafka internal consumer offsets topic (__consumer_offsets) explicitly a local Redpanda topic by setting its redpanda.storage.mode at creation time, aligning the topic configuration with its existing non-tiered behavior in the Kafka subsystem.
Changes:
- Set
topic.properties.storage_modetomodel::redpanda_storage_mode::localinconsumer_offsets_topic_configuration.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
72
to
75
| topic.properties.cleanup_policy_bitflags | ||
| = model::cleanup_policy_bitflags::compaction; | ||
| topic.properties.storage_mode = model::redpanda_storage_mode::local; | ||
| // allow creation even if a consumer group migration is in progress |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The offsets topic has pretty much been local in all but name: it explicitly doesn't construct an archiver, and the local storage layer explicitly prevents truncating it. It's never relied on tiered storage for disaster recovery since that is handled through separate snapshotting code.
This commit makes this explicit, creating the topic as an explicit local topic.
Backports Required
Release Notes