chore(e2e): remove the plugin sanity checks, now in the overlays repo by gustavolira · Pull Request #5728 · redhat-developer/rhdh

gustavolira · 2026-10-26T19:14:37Z

Summary

Plugin sanity now lives in rhdh-plugin-export-overlays (#4536, release-plugin-sanity.yaml). It boots the real RHDH image of a CI chart with every catalog-index and community plugin enabled. It runs daily for main and release-2.1, and on demand with /sanity <chart> on #4557. Both checks in this repo cover a subset of that, so this PR removes them:

.ci/pipelines
  jobs/ocp-nightly.sh          - run_sanity_plugins_check (showcase-sanity-plugins in the OCP Helm nightly)
  utils.sh                     - initiate_sanity_plugin_checks_deployment
  lib/testing.sh               - testing::report_plugin_startup_failures (only caller removed)
  env_variables.sh             - HELM_CHART_SANITY_PLUGINS_*, NAME_SPACE_SANITY_PLUGINS_CHECK
  value_files/diff-values_showcase-sanity-plugins.yaml   (deleted)
.github/workflows/e2e-cluster-free.yaml   - plugin-sanity job + the schedule/dispatch triggers only it used
e2e-tests
  playwright.plugin-sanity.config.ts, support/plugin-sanity-global-setup.ts,
  cluster-free/plugin-dynamic-loading.spec.ts, utils/installed-plugins.ts,
  support/api/dynamic-plugins-api.ts (+ their unit tests)                   (deleted)
  local-harness/{populate-catalog-index,catalog-index-refs,filter-plugin-startup-failures}.sh,
  app-config.plugin-sanity.yaml, plugin-sanity-excludes.txt                  (deleted)
  playwright/projects.json, playwright.config.ts, package.json - showcase-sanity-plugins project and scripts
docs/                                      - point at the overlays workflow

The four showcase specs the project shared keep running in showcase, showcase-upgrade and the localization projects. Shared helpers lose only the parameters that only the sanity check passed (populate.sh config argument, extraConfigs in local-harness-servers.ts).

Which issue(s) does this PR fix

RHIDP-18205, RHIDP-18257

Evidence

Before: the OCP Helm nightly deploys a separate showcase-sanity-plugins namespace with a pinned plugin list. e2e-cluster-free.yaml runs a daily plugin-sanity job against the next catalog index.
After: both are gone. The overlays check ran on 2.1-173-CI: 148 plugins requested, 147 installed, 147 loaded (run). One plugin is excluded on purpose.

Testing

e2e-tests: yarn fmt:check ok. yarn tsc --noEmit -p . ok. yarn test:unit: 221 passed, 1 skipped. yarn shellcheck ok. yarn playwright test --list --project=showcase still lists 38 tests.
.ci: yarn shellcheck and yarn prettier:check ok.
yarn lint reports one error, playwright/utils/kube-client/index.ts:78 no-unsafe-member-access. That file is not touched here, and origin/main has the same error.
No job in openshift/release references the project; it was only called from ocp-nightly.sh.

Merge Danger

Door: two-way.

Blast radius: CI-only.

How to revert

git revert <merge commit>

PR acceptance criteria

GitHub Actions are completed and successful
Unit Tests are updated and passing
E2E Tests are updated and passing
Documentation is updated if necessary (requirement for new features)
Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

This PR touches main only, so the rhdh release branches keep their cluster sanity until it is removed there. On the overlays side, the daily run covers main and release-2.1 once overlays#4559 and overlays#4558 merge. Other streams can be checked on demand with /sanity <chart>.

The second commit also drops the catalog_index_image input of resolve-catalog-index-image, whose only caller was the removed dispatch input. It also fixes a CI medic guide block this PR edits: localization tests run in their own job, not in the OCP Helm nightly.

With the plugin-sanity job gone, e2e-cluster-free.yaml goes back to the repo's standard concurrency group (no github.event_name, since only pull_request/push remain), and setup-cluster-free-harness stops installing jq, which only catalog-index-refs.sh used.

🤖 Generated with Claude Code

Plugin sanity moved to rhdh-plugin-export-overlays (release-plugin-sanity.yaml, redhat-developer/rhdh-plugin-export-overlays#4536). It boots the real RHDH image of a CI chart with every catalog-index and community plugin, daily for main and release-2.1 and on demand with /sanity <chart>, so neither check here adds coverage any more. Removed: - the showcase-sanity-plugins project from the OCP Helm nightly: its deployment, value file, env variables and the pod-log startup-failure report; - the cluster-free plugin-sanity job (scheduled and dispatch-only), its Playwright config, global setup, spec, catalog-index populate scripts, excludes and the helpers and unit tests only it used. The four showcase specs it shared keep running in showcase, upgrade and the localization projects. Docs now point at the overlays workflow. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

codecov · 2026-10-26T19:16:59Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.04%. Comparing base (aa87c99) to head (7bc2909).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5728      +/-   ##
==========================================
- Coverage   75.70%   73.04%   -2.67%     
==========================================
  Files          65       61       -4     
  Lines         708      575     -133     
  Branches      100       83      -17     
==========================================
- Hits          536      420     -116     
+ Misses        171      154      -17     
  Partials        1        1

Flag	Coverage Δ
rhdh	`69.00% <ø> (-6.70%)`	⬇️
rhdh-e2e-frontend	`72.00% <ø> (?)`

Components	Coverage Δ
Backend plugins	`∅ <ø> (∅)`
Backend app	`78.94% <ø> (ø)`
Frontend app	`68.59% <ø> (+7.55%)`	⬆️

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa87c99...7bc2909. Read the comment docs.

🚀 New features to boost your workflow:

📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions · 2026-10-26T19:29:05Z

Image was built and published successfully. It is available at:

The catalog_index_image input of resolve-catalog-index-image and its validation branch had a single caller, the plugin-sanity dispatch input removed in the previous commit. Also fix the CI medic guide block this PR edits: localization tests do not run in handle_ocp_nightly but in their own job. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

- CI medic guide: the example artifact tree for e2e-ocp-helm-nightly still listed showcase-localization-* directories, contradicting the corrected "Test suites run" block below it. Localization runs in its own job, so the nightly tree ends at showcase-runtime. - e2e-cluster-free.yaml: the defaults comment justified bash with `[[ ]]`/`=~` steps, which only the removed plugin-sanity job had. Keep bash, state the reason that still holds. - playwright.local.config.ts: the header pointed at "alternatives" in local-e2e-harness.md; that section (the catalog-index populate) is gone, and what remains there is the release-branch index example. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

github-actions · 2026-10-26T19:46:47Z

Image was built and published successfully. It is available at:

sonarqubecloud · 2026-10-26T19:47:00Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions · 2026-10-26T20:02:15Z

Image was built and published successfully. It is available at:

zdrapela · 2026-10-27T09:07:13Z

/test e2e-ocp-helm-nightly

zdrapela · 2026-10-27T09:15:59Z

/agentic_review

rhdh-qodo-merge · 2026-10-27T09:17:12Z

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Powered by Qodo

openshift-ci · 2026-10-27T11:42:34Z

@gustavolira: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-ocp-helm-nightly	`7bc2909`	link	false	`/test e2e-ocp-helm-nightly`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

zdrapela · 2026-10-27T11:58:16Z

/lgtm

openshift-ci Bot requested review from PatAKnight and schultzp2020 October 26, 2026 19:14

gustavolira and others added 2 commits October 26, 2026 16:31

openshift-ci Bot assigned zdrapela Oct 27, 2026

openshift-ci Bot added the lgtm label Oct 27, 2026

openshift-merge-bot Bot merged commit 6f85468 into redhat-developer:main Oct 27, 2026
31 of 32 checks passed

Navigation Menu

Repository navigation

chore(e2e): remove the plugin sanity checks, now in the overlays repo - #5728

chore(e2e): remove the plugin sanity checks, now in the overlays repo#5728
openshift-merge-bot[bot] merged 3 commits into
redhat-developer:mainfrom
gustavolira:chore/remove-sanity-plugins-check

gustavolira commented Oct 26, 2026 •

edited

Loading

Uh oh!

codecov Bot commented Oct 26, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 26, 2026

Uh oh!

github-actions Bot commented Oct 26, 2026

Uh oh!

sonarqubecloud Bot commented Oct 26, 2026

Uh oh!

github-actions Bot commented Oct 26, 2026

Uh oh!

zdrapela commented Oct 27, 2026

Uh oh!

zdrapela commented Oct 27, 2026

Uh oh!

rhdh-qodo-merge Bot commented Oct 27, 2026

Uh oh!

openshift-ci Bot commented Oct 27, 2026

Uh oh!

zdrapela commented Oct 27, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

gustavolira commented Oct 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Which issue(s) does this PR fix

Evidence

Testing

Merge Danger

How to revert

PR acceptance criteria

How to test changes / Special notes to the reviewer

Uh oh!

codecov Bot commented Oct 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions Bot commented Oct 26, 2026

Uh oh!

github-actions Bot commented Oct 26, 2026

Uh oh!

sonarqubecloud Bot commented Oct 26, 2026

Quality Gate passed

Uh oh!

github-actions Bot commented Oct 26, 2026

Uh oh!

zdrapela commented Oct 27, 2026

Uh oh!

zdrapela commented Oct 27, 2026

Uh oh!

rhdh-qodo-merge Bot commented Oct 27, 2026

Code Review by Qodo

Great, no issues found!

Uh oh!

openshift-ci Bot commented Oct 27, 2026

Uh oh!

zdrapela commented Oct 27, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

gustavolira commented Oct 26, 2026 •

edited

Loading

codecov Bot commented Oct 26, 2026 •

edited

Loading