Repository navigation
chore(agents): consolidate AI tooling to AGENTS.md + .agents/ and record ADRs - #5696
Conversation
…abels, domain docs)
…standard - Remove rulesync and its generated outputs (.claude/, .cursor/, .opencode/, opencode.jsonc, .cursorignore, .rulesyncignore, rulesync.jsonc) - Remove Codium PR-Agent config (.pr_agent.toml) - Move skills to .agents/skills/ (Agent Skills open standard); convert former rulesync commands (fix-e2e, pr-triage, pr-review-prioritizer, trigger-nightly-job) to skills - Consolidate rules knowledge into CONTEXT.md - Drop rulesync scripts, devDependency, lint-staged rules, and CI sync check
- CONTEXT.md, e2e-tests/README.md, patch-backstage and e2e-submit-and-review skills: point at .agents/ + CONTEXT.md - codecov.yml, .dockerignore, .gitignore, e2e-tests/.gitignore: drop stale ignore entries - e2e-tests semantic selectors: repoint playwright-locators doc ref - eol-inventory: drop rulesync dependency row - AGENTS.md: add rule forbidding vendored harness dotfile directories
…/knowledge/ - Split the six consolidated knowledge docs into topical files under docs/agents/knowledge/ - CONTEXT.md becomes a high-level orientation + knowledge index - Rule: detailed knowledge gets its own file/dir, never dumped into CONTEXT.md
- AGENTS.md: drop duplicated label list, rephrase no-dotfiles rule as positive entry-points rule (negation → elephant effect) - CONTEXT.md: drop negation and conventions duplicating AGENTS.md - Skills/knowledge: strip stale rulesync frontmatter (targets/root/globs), repoint 'rule' references at docs/agents/knowledge/ paths - e2e-fix-workflow.md: drop workflow overview duplicated in fix-e2e skill; keep mapping tables as the single source of truth - e2e-testing.md: title matches content (was 'Repository Context') - Remove .vscode/extensions.json and opencode.json ignore entry
…gins-root - REVIEW.md: review guide per Anthropic code-review practice — failure modes, evidence rules, nit cap, skip paths, convergence rules - PR template: add Summary/Evidence/Testing/Merge Danger/How to revert (pr skill + Anthropic recommendations) alongside existing criteria - Restore dynamic-plugins-root/.gitkeep (accidentally deleted in 9c2e236); CONTEXT.md points at the right dynamic plugins path
- 0001: dynamic plugins as the plugin delivery model (PR #522/#599) - 0002: E2E on real ephemeral clusters via OpenShift CI/Prow, rationale confirmed from RHIDP-1687 (re-trigger + artifact storage) - 0003: yarn patches for downstream fixes on released upstream packages - 0004: OCI catalog index (ref://) plugin distribution, drivers confirmed from RHIDP-10847 and RHIDP-13226 REVIEW.md: flag plugin-version PRs that bypass the catalog index
|
Skipping CI for Draft Pull Request. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5696 +/- ##
==========================================
- Coverage 75.70% 69.00% -6.70%
==========================================
Files 65 58 -7
Lines 708 555 -153
Branches 100 83 -17
==========================================
- Hits 536 383 -153
Misses 171 171
Partials 1 1
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Repo-root-relative links broke when the knowledge docs moved from .rulesync/rules/ (unscanned) into docs/ (markdown-link-check scope): prefix with ../../../ from the new location. The dead catalog-entities/extensions/README.md reference is de-linked; that tree no longer exists.
|
The container image build workflow finished with status: |
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
|
The container image build workflow finished with status: |
|
|
@schultzp2020: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
The |
| # Private Keys | ||
| *.pem | ||
|
|
||
| # Local AI Assistant rules |
There was a problem hiding this comment.
I think deleting all of those gitignores will cause issues for people using local configs.
I personally use OpenCode and .opencode/package-lock.json has to remain gitignored, or it will lead to accidental commits of this file.
There was a problem hiding this comment.
Tool-specific configs like this are best handled in a user’s global .gitignore rather than the repository's .gitignore. With so many different editors and AI tools available now, keeping these local prevents our root ignore file from becoming bloated with individual developer configurations.
There was a problem hiding this comment.
This file was used to configure Qodo on this repository. It's no longer the recommended way, but a functional way. It's good to know what you delete before you do so.
I opened https://redhat.atlassian.net/browse/RHIDP-18214 to follow up and move the configuration to the Qodo portal so we don't lose the config.
There was a problem hiding this comment.
Thank you and my apologies for missing this. Can you add something in the AGENTS.md file about it's purpose when you update the config?
There was a problem hiding this comment.
No problem. Since the file is already deleted, I think I'll move the config off the file into Qodo Portal: https://app.redhat.st.qodo.ai/configurations?provider=github&repo=redhat-developer%2Frhdh&tab=general-review as this is the recommended way these days.
I can use AGENTS.md if I add something similar in the future, but git history would probably work similarly well in this case.
There was a problem hiding this comment.
Does it make sense to record the ADRs here? I thought we settled on using https://github.com/redhat-developer/rhdh-adr, as recorded in https://github.com/redhat-developer/rhdh-adr/blob/main/decisions/000-adopt-adrs-for-architectural-decisions.md
There was a problem hiding this comment.
I'll add this as a topic on the next team forum call.
There was a problem hiding this comment.
Claude Code loads nothing from .agents/skills/. It only supports .claude/skills/. I believe there are still people on the team who use Claude Code. There should be a symlink.
There was a problem hiding this comment.
I'm open to symlinking using the npx skills command if people are still using CC. I will add this as a topic too.
Summary
Consolidates every AI-harness surface in this repo onto one standard (
AGENTS.md+.agents/+CONTEXT.md+docs/agents/) and records the architectural decisions behind the repo's current shape as ADRs.Which issue(s) does this PR fix
None — agentic repo hygiene. ADR rationale confirmed against RHIDP-1687, RHIDP-10847, RHIDP-13226.
Evidence
.claude/,.cursor/,.opencode/,.rulesync/,.pr_agent.toml) plus a rulesync generation pipeline (scripts, devDependency, lint-staged rules, CI sync check).docs/agents/knowledge/; ADRs document the dynamic-plugins delivery model, Prow-based E2E, yarn-patch upstream strategy, and OCI catalog-index distribution — all verified still in force onmain, with git evidence and Jira-confirmed rationale.Testing
Config, docs, and skill files only — no runtime code changed.
yarn installandyarn lint-stagedpass after therulesyncdevDependency removal;package.jsonparses.Merge Danger
Door: two-way
Blast radius: developer tooling
Anyone relying on
.claude/,.cursor/, or.opencode/output locally will need to point their harness atAGENTS.md/.agents/skills/instead.How to revert
git revert -m 1 <merge-commit>— no data or generated artifacts depend on the new layout.PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer
Review order suggestion:
AGENTS.md(the pointers) →CONTEXT.md+docs/agents/(the layout) →REVIEW.md(reviewer contract) →docs/adr/(records only, no behavior). The four converted command-skills (fix-e2e,pr-triage,pr-review-prioritizer,trigger-nightly-job) are verbatim moves from.rulesync/commands/with frontmatter rewritten — diff against78ea60d8dto verify no content drift.