fix(orchestrator): detect GitHub SAML SSO session expiry and prompt users to re-authorize#3253
Open
karthikjeeyar wants to merge 3 commits into
Open
Conversation
karthikjeeyar
requested review from
a team,
christoph-jerolimov,
lholmquist and
lokanandaprabhu
as code owners
karthikjeeyar
force-pushed
the
orchestrator/saml-sso-error
branch
from
6776cee to
462448f
Compare
Changed Packages
|
karthikjeeyar
force-pushed
the
orchestrator/saml-sso-error
branch
2 times, most recently
from
3b658c2 to
6c068e2
Compare
karthikjeeyar
force-pushed
the
orchestrator/saml-sso-error
branch
from
6c068e2 to
1428c7e
Compare
karthikjeeyar
commented
May 29, 2026
Comment on lines
+177
to
+184
| // TODO: This will be removed before merging, it's only here to simulate GitHub SAML SSO errors during developmen and testing. | ||
| if (localStorage.getItem('SIMULATE_SAML_SSO_ERROR') === 'true') { | ||
| const samlError = new Error( | ||
| 'GitHub SAML SSO session expired. Re-authorize at: https://github.com/orgs/test-org/sso', | ||
| ); | ||
| onSamlSsoError?.(samlError); | ||
| return; | ||
| } |
Member
Author
There was a problem hiding this comment.
Added this block so reviewers can simulate this sso error by setting localStorage.setItem('SIMULATE_SAML_SSO_ERROR', true) in thee browser console.
This will be removed before merging.
Signed-off-by: Karthik <karthik.jk11@gmail.com>
Signed-off-by: Karthik <karthik.jk11@gmail.com>
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3253 +/- ##
==========================================
- Coverage 53.29% 53.27% -0.02%
==========================================
Files 2407 2408 +1
Lines 86420 86473 +53
Branches 23957 23972 +15
==========================================
+ Hits 46056 46070 +14
- Misses 38887 38929 +42
+ Partials 1477 1474 -3
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
Fixes: https://redhat.atlassian.net/browse/RHDHBUGS-3216
Changes included in this PR:
x-github-ssoresponse header when availableScreenshots:
How to Test:
Create these workflow and schema files:
packages/backend/.devModeTemp/repository/workflows/github-sso-test.sw.yamlpackages/backend/.devModeTemp/repository/workflows/schemas/github-sso-test-input-schema.jsonstart the application using
yarn devSet the simulate sso variable in localstorage
localStorage.setItem('SIMULATE_SAML_SSO_ERROR', true)Execute the
Github SSO Testworkflow by visiting http://localhost:3000/orchestrator/workflows/github-sso-test/executeNOTE:
SIMULATE_SAML_SSO_ERRORlogic is only added for the testing purpose, I will remove this before merging it.✔️ Checklist