Skip to content

chore(deps): update dependency setuptools to v84 [security] (release-1.10) - #534

Open
renovate[bot] wants to merge 1 commit into
release-1.10from
renovate/release-1.10-pypi-setuptools-vulnerability
Open

renovate[bot] wants to merge 1 commit into
release-1.10from
renovate/release-1.10-pypi-setuptools-vulnerability

Conversation

@renovate

@renovate renovate Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Change Age Confidence
setuptools (changelog) ==82.0.1 → ==84.1.0 age confidence

setuptools: MANIFEST.in exclusion bypass in sdist via Unicode normalization collision (NFC/NFD) on macOS APFS/HFS+

BIT-setuptools-2026-59890 / CVE-2026-59890 / GHSA-h35f-9h28-mq5c / PYSEC-2026-3447

More information

Details

Summary

When building a source distribution (python -m build --sdist / setup.py sdist), setuptools' FileList applies MANIFEST.in directives (exclude, global-exclude, recursive-exclude, prune) by matching a compiled glob against on-disk file names byte-for-byte, with no Unicode normalization. On normalization-preserving filesystems (notably macOS APFS and HFS+), a file written in NFD and a MANIFEST.in rule written in NFC refer to the same file but are byte-distinct, so the exclusion silently fails to match. A file the maintainer intended to exclude is then packed into the .tar.gz and, if published, uploaded to the public, immutable PyPI index.

Details

File names in FileList.files come from os.walk (setuptools/_distutils/filelist.py, _find_all_simple), so on APFS a file written NFD is offered to the matcher in NFD, while the MANIFEST.in pattern carries the author's editor form (typically NFC). The matching path performs no canonicalization:

##### setuptools/command/egg_info.py  (FileList.global_exclude)
def global_exclude(self, pattern):
    match = translate_pattern(os.path.join('**', pattern))   # fnmatch.translate -> regex, no NFC/NFD
    return self._remove_files(match.match)                   # byte-level regex over raw os.walk names

A rule written NFC (café = 63 61 66 c3 a9) does not match an on-disk name written NFD (café = 63 61 66 65 cc 81), even though the filesystem treats the two as one file.

A unicodedata.normalize('NFD', ...) helper exists in setuptools/unicode_utils.py (decompose()), but it is never called in the manifest matching path, so neither the pattern nor the walked path is normalized before matching. The only normalization in this area, EggInfoCommand._manifest_normalize, uses filesys_decode (bytes→str decode only, no NFC/NFD) and runs when writing SOURCES.txt, after matching has already occurred.

Impact

MANIFEST.in exclusions are the documented mechanism maintainers use to keep secrets, local configs, and private fixtures out of the published sdist. A non-ASCII excluded file may be published to the public, immutable PyPI index despite the rule — an irreversible disclosure with no visual cue (NFC and NFD forms render identically). Exposure is filesystem-dependent and most relevant on macOS APFS/HFS+, where many maintainers build and publish. Pure-ASCII rules are unaffected.

Proof of concept

With a project containing MANIFEST.in:

global-include *.txt *.json
global-exclude secret_café.txt    # rule saved NFC

and an on-disk file secret_café.txt written in NFD, python -m build --sdist packs the secret file into the resulting .tar.gz, while an ASCII control file excluded by the same directive is correctly dropped — isolating the bypass to the NFC-pattern vs. NFD-name mismatch. Reproduced on macOS APFS with setuptools 82.0.1.

Remediation

Normalize both the walked path and each MANIFEST.in pattern to a single canonical form before matching, in both setuptools/command/egg_info.py (FileList) and the vendored setuptools/_distutils/filelist.py. For an exclusion list, err toward excluding more, and document that MANIFEST.in matching is normalization-insensitive on macOS.

Credit

Reported by Tomas Illuminati. Coordinated via CERT/CC VINCE VU#604762.

Severity

  • CVSS Score: 6.1 / 10 (Medium)
  • Vector String: CVSS:3.1/AV:L/AC:L/PR:N/UI:R/S:U/C:H/I:L/A:N

References

This data is provided by OSV and the GitHub Advisory Database (CC-BY 4.0).


BIT-setuptools-2026-59890 / CVE-2026-59890 / GHSA-h35f-9h28-mq5c / PYSEC-2026-3447

More information

Details

setuptools is a package that allows users to download, build, install, upgrade, and uninstall Python packages. Prior to 83.0.0, FileList applied MANIFEST.in exclude, global-exclude, recursive-exclude, and prune directives by matching compiled glob patterns against on-disk file names without Unicode normalization, so on macOS APFS or HFS+ an NFD file name could bypass an NFC exclusion rule and be packed into a source distribution. This issue is fixed in version 83.0.0.

Severity

  • CVSS Score: 6.1 / 10 (Medium)
  • Vector String: CVSS:3.1/AV:L/AC:L/PR:N/UI:R/S:U/C:H/I:L/A:N

References

This data is provided by OSV and the PyPI Advisory Database (CC-BY 4.0).


setuptools: Windows path escape via namespace_packages.txt during legacy wheel installation Description

GHSA-xmj3-9gf7-h52w

More information

Details

Summary

On Windows, attacker-controlled content in a wheel's
.dist-info/namespace_packages.txt can cause setuptools' legacy wheel
installation path to create an __init__.py outside the requested
destination_eggdir.

The attacker can influence the destination path, but not the contents of
the created file.

Details

Tested setuptools commit:

6ead555c5fb29bc57fe6105b1bffc163f56fd558

Relevant source:

setuptools/wheel.py

SHA-256:

359b7e0d5dd8c3135653abe08a8ed5dc0352eadfd7df22cb5e2b5303b7c3cafd

The relevant call path is:

Wheel(wheel_path).install_as_egg(destination)
→ _install_as_egg
→ _convert_metadata
→ _fix_namespace_packages

A wheel can provide attacker-controlled content in:

<distribution>.dist-info/namespace_packages.txt

The namespace value is eventually used approximately as:

mod_dir = os.path.join(destination_eggdir, *mod.split('.'))
mod_init = os.path.join(mod_dir, '__init__.py')

If mod is a Windows drive-qualified absolute path containing no dots,
mod.split('.') preserves it as a single component.
On Windows, os.path.join(destination_eggdir, absolute_component) discards
the original base directory and resolves to the attacker-supplied absolute
path.
The existing wheel filename and ZIP traversal checks do not validate this
metadata value before it is subsequently interpreted as a filesystem path.

```markdown

##### PoC

The reproduction was performed entirely inside a disposable temporary
directory.

Layout:

```text
sandbox/
    destination/
    outside/
    input/
    canary.txt

A synthetic wheel was created containing:

demo_pkg-1.0.dist-info/namespace_packages.txt

whose content was the absolute path of:

sandbox\outside

The real acquired setuptools implementation was then invoked:

setuptools.wheel.Wheel(synthetic_wheel).install_as_egg(
    sandbox_destination
)

The operation completed without exception.

Expected metadata was created under:

sandbox\destination\EGG-INFO

but setuptools also created:

sandbox\outside\__init__.py

The file did not exist before execution.

Its contents were:

__import__('pkg_resources').declare_namespace(__name__)

The unrelated canary remained byte-identical.

The sandbox was deleted after recording the evidence.


##### Impact

A crafted wheel can cause setuptools to create a fixed-content
`__init__.py` outside the intended installation directory at a
filesystem path influenced by the wheel, with the permissions of the
process performing the installation.

The demonstrated reproduction required the target parent directory to
already exist.

#### Severity
- CVSS Score: 1.0 / 10 (Low)
- Vector String: `CVSS:4.0/AV:L/AC:H/AT:P/PR:L/UI:A/VC:N/VI:L/VA:L/SC:N/SI:N/SA:N`

#### References
- [https://github.com/pypa/setuptools/security/advisories/GHSA-xmj3-9gf7-h52w](https://redirect.github.com/pypa/setuptools/security/advisories/GHSA-xmj3-9gf7-h52w)
- [https://github.com/pypa/setuptools/pull/5329](https://redirect.github.com/pypa/setuptools/pull/5329)
- [https://github.com/pypa/setuptools/commit/6d07b8d17890dda58d944ac51e58f54af92d52af](https://redirect.github.com/pypa/setuptools/commit/6d07b8d17890dda58d944ac51e58f54af92d52af)
- [https://github.com/pypa/setuptools](https://redirect.github.com/pypa/setuptools)
- [https://github.com/pypa/setuptools/releases/tag/v84.1.0](https://redirect.github.com/pypa/setuptools/releases/tag/v84.1.0)

This data is provided by [OSV](https://osv.dev/vulnerability/GHSA-xmj3-9gf7-h52w) and the [GitHub Advisory Database](https://redirect.github.com/github/advisory-database) ([CC-BY 4.0](https://redirect.github.com/github/advisory-database/blob/main/LICENSE.md)).
</details>

---

### Release Notes

<details>
<summary>pypa/setuptools (setuptools)</summary>

### [`v84.1.0`](https://redirect.github.com/pypa/setuptools/compare/v84.0.0...v84.1.0)

[Compare Source](https://redirect.github.com/pypa/setuptools/compare/v84.0.0...v84.1.0)

### [`v84.0.0`](https://redirect.github.com/pypa/setuptools/compare/v83.0.0...v84.0.0)

[Compare Source](https://redirect.github.com/pypa/setuptools/compare/v83.0.0...v84.0.0)

### [`v83.0.0`](https://redirect.github.com/pypa/setuptools/compare/v82.0.1...v83.0.0)

[Compare Source](https://redirect.github.com/pypa/setuptools/compare/v82.0.1...v83.0.0)

</details>

---

### Configuration

📅 **Schedule**: (UTC)

- Branch creation
  - At any time (no schedule defined)
- Automerge
  - At any time (no schedule defined)

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/redhat-developer/rhdh-must-gather).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0NC4xNjQuMSIsInVwZGF0ZWRJblZlciI6IjQ0LjE4OC4yIiwidGFyZ2V0QnJhbmNoIjoicmVsZWFzZS0xLjEwIiwibGFiZWxzIjpbImtpbmQvZGVwZW5kZW5jeSB1cGdyYWRlIiwia2luZC9zZWN1cml0eSJdfQ==-->

@renovate renovate Bot changed the title Update dependency setuptools to v83 [SECURITY] (release-1.10) chore(deps): update dependency setuptools to v83 [security] (release-1.10) Oct 16, 2026
@renovate renovate Bot changed the title chore(deps): update dependency setuptools to v83 [security] (release-1.10) Update dependency setuptools to v83 [SECURITY] (release-1.10) Oct 16, 2026
@renovate renovate Bot changed the title Update dependency setuptools to v83 [SECURITY] (release-1.10) chore(deps): update dependency setuptools to v83 [security] (release-1.10) Oct 16, 2026
@renovate renovate Bot changed the title chore(deps): update dependency setuptools to v83 [security] (release-1.10) Update dependency setuptools to v83 [SECURITY] (release-1.10) Oct 16, 2026
@renovate renovate Bot changed the title Update dependency setuptools to v83 [SECURITY] (release-1.10) chore(deps): update dependency setuptools to v83 [security] (release-1.10) Oct 16, 2026
@renovate renovate Bot changed the title chore(deps): update dependency setuptools to v83 [security] (release-1.10) chore(deps): update dependency setuptools to v83 [security] (release-1.10) - autoclosed Oct 17, 2026
@renovate renovate Bot closed this Oct 17, 2026
@renovate
renovate Bot deleted the renovate/release-1.10-pypi-setuptools-vulnerability branch October 17, 2026 14:16
@renovate renovate Bot changed the title chore(deps): update dependency setuptools to v83 [security] (release-1.10) - autoclosed Update dependency setuptools to v83 [SECURITY] (release-1.10) Oct 20, 2026
@renovate renovate Bot reopened this Oct 20, 2026
@renovate
renovate Bot force-pushed the renovate/release-1.10-pypi-setuptools-vulnerability branch from e858254 to e4e7bc7 Compare October 20, 2026 13:54
@rm3l

rm3l commented Oct 20, 2026

Copy link
Copy Markdown
Member

/hold — code freeze active for 1.10.6.

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Used by Prow. label Oct 20, 2026
@renovate renovate Bot changed the title Update dependency setuptools to v83 [SECURITY] (release-1.10) chore(deps): update dependency setuptools to v83 [security] (release-1.10) Oct 20, 2026
@renovate renovate Bot changed the title chore(deps): update dependency setuptools to v83 [security] (release-1.10) chore(deps): update dependency setuptools to v83 [security] (release-1.10) - autoclosed Oct 21, 2026
@renovate renovate Bot closed this Oct 21, 2026
@renovate renovate Bot changed the title chore(deps): update dependency setuptools to v83 [security] (release-1.10) - autoclosed Update dependency setuptools to v83 [SECURITY] (release-1.10) Oct 22, 2026
@renovate renovate Bot reopened this Oct 22, 2026
@renovate
renovate Bot force-pushed the renovate/release-1.10-pypi-setuptools-vulnerability branch 3 times, most recently from 0f04ec5 to 81f481f Compare October 22, 2026 15:54
@renovate renovate Bot changed the title Update dependency setuptools to v83 [SECURITY] (release-1.10) chore(deps): update dependency setuptools to v83 [security] (release-1.10) Oct 22, 2026
@renovate renovate Bot changed the title chore(deps): update dependency setuptools to v83 [security] (release-1.10) chore(deps): update dependency setuptools to v83 [security] (release-1.10) - autoclosed Oct 23, 2026
@renovate renovate Bot closed this Oct 23, 2026
@renovate renovate Bot changed the title chore(deps): update dependency setuptools to v83 [security] (release-1.10) - autoclosed Update dependency setuptools to v83 [SECURITY] (release-1.10) Oct 23, 2026
@renovate renovate Bot reopened this Oct 23, 2026
@renovate
renovate Bot force-pushed the renovate/release-1.10-pypi-setuptools-vulnerability branch 2 times, most recently from 81f481f to d67aee2 Compare October 23, 2026 15:49
@renovate renovate Bot changed the title Update dependency setuptools to v83 [SECURITY] (release-1.10) chore(deps): update dependency setuptools to v83 [security] (release-1.10) Oct 23, 2026
@renovate
renovate Bot force-pushed the renovate/release-1.10-pypi-setuptools-vulnerability branch from d67aee2 to 4b22bc5 Compare October 23, 2026 16:07
@renovate renovate Bot changed the title chore(deps): update dependency setuptools to v83 [security] (release-1.10) chore(deps): update dependency setuptools to v84 [security] (release-1.10) Oct 24, 2026
@renovate
renovate Bot force-pushed the renovate/release-1.10-pypi-setuptools-vulnerability branch from 4b22bc5 to 0380452 Compare October 24, 2026 02:28
@renovate renovate Bot changed the title chore(deps): update dependency setuptools to v84 [security] (release-1.10) Update dependency setuptools to v84 [SECURITY] (release-1.10) Oct 26, 2026
@renovate renovate Bot changed the title Update dependency setuptools to v84 [SECURITY] (release-1.10) Update dependency setuptools to v84 [SECURITY] (release-1.10) - autoclosed Oct 27, 2026
@renovate renovate Bot closed this Oct 27, 2026
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate renovate Bot changed the title Update dependency setuptools to v84 [SECURITY] (release-1.10) - autoclosed Update dependency setuptools to v84 [SECURITY] (release-1.10) Oct 27, 2026
@renovate renovate Bot reopened this Oct 27, 2026
@renovate
renovate Bot force-pushed the renovate/release-1.10-pypi-setuptools-vulnerability branch 2 times, most recently from 0380452 to dbebb33 Compare October 27, 2026 13:49
@renovate renovate Bot changed the title Update dependency setuptools to v84 [SECURITY] (release-1.10) chore(deps): update dependency setuptools to v84 [security] (release-1.10) Oct 27, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Used by Prow. kind/dependency upgrade kind/security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant