Skip to content

chore: update rhdh-supported-plugins.sh to pull from both community and supported catalog index - #2685

Merged
nickboldt merged 5 commits into
redhat-developer:release-2.1from
Zaperex:use-both-catalog-index
Oct 22, 2026
Merged

nickboldt merged 5 commits into
redhat-developer:release-2.1from
Zaperex:use-both-catalog-index

Conversation

@Zaperex

@Zaperex Zaperex commented Oct 21, 2026

Copy link
Copy Markdown
Member

Now that the community dynamic plugins table is generated and published in the community catalog index, this PR updates the rhdh-supported-plugins.sh script to consume the community dynamic plugins table from there instead of generating it on the fly.

IMPORTANT: Do Not Merge - To be merged by Docs Team Only

Version(s): 2.1

Issue: RHDHBUGS-3942

Preview:

Signed-off-by: Frank Kong <frkong@redhat.com>

rh-pre-commit.version: 2.4.0
rh-pre-commit.check-secrets: ENABLED
…and supported catalog index for plugin tables

Assisted-By: Codex
Signed-off-by: Frank Kong <frkong@redhat.com>

rh-pre-commit.version: 2.4.0
rh-pre-commit.check-secrets: ENABLED
@rhdh-bot

Copy link
Copy Markdown
Collaborator

Shellcheck Analysis Results

Changed shell scripts in this PR: 1

Scripts analyzed:

  • modules/extend_dynamic-plugins-reference/rhdh-supported-plugins.sh

Check the Files changed tab for detailed shellcheck suggestions.

All findings are reported as warnings and won't block the PR.


Automated shellcheck analysis • See shellcheck.net for details

@Zaperex

Zaperex commented Oct 21, 2026

Copy link
Copy Markdown
Member Author

/cherrypick main

@openshift-cherrypick-robot

Copy link
Copy Markdown
Contributor

@Zaperex: once the present PR merges, I will cherry-pick it on top of main in a new PR and assign it to you.

Details

In response to this:

/cherrypick main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@rhdh-bot

rhdh-bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Collaborator

PR Build Results

Build passed -- 1/1 titles | 51s
Preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-2685/


Content Quality Assessment

CQA Report

  • CQA-00a: Orphaned modules
  • CQA-00b: Directory structure
  • CQA-01: Vale AsciiDoc DITA compliance
  • CQA-02: Verify assembly structure
  • CQA-03: Verify content type metadata
  • CQA-04: Verify module templates
  • CQA-05: Verify required modular elements
  • CQA-06: Verify assemblies follow official template (one user story)
  • CQA-07: Verify TOC depth (max 3 levels)
  • CQA-08: Verify short description content quality
  • CQA-09: Verify short description format
  • CQA-10: Verify titles are brief, complete, and descriptive
  • CQA-11: Verify procedure prerequisites
  • CQA-12: Verify grammar and style (Vale)
  • CQA-13: Verify content matches declared type
  • CQA-14: Verify no broken links
  • CQA-14b: Inbound link stability (no ID changes for existing files)
  • CQA-15: Check redirects
  • CQA-16: Verify official product names
  • CQA-17: Verify legal disclaimers for preview features
  • CQA-jtbd-01: Verify navigation file structure
  • CQA-jtbd-02: Modules not yet in product_product (informational)

Summary

Checks: 22 total, 22 pass, 0 fail

22 checks: 22 pass, 0 fail

Run node build/scripts/cqa/index.js --all --fix locally to review and auto-fix issues.


Updated 2026-10-22 12:13:45 UTC

Signed-off-by: Frank Kong <frkong@redhat.com>

rh-pre-commit.version: 2.4.0
rh-pre-commit.check-secrets: ENABLED
Comment thread modules/extend_dynamic-plugins-reference/rhdh-supported-plugins.sh Outdated
Comment thread modules/extend_dynamic-plugins-reference/rhdh-supported-plugins.sh Outdated
Comment thread modules/extend_dynamic-plugins-reference/rhdh-supported-plugins.sh
Co-authored-by: Nick Boldt <nboldt@redhat.com>

@nickboldt nickboldt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor adjustments, looks good!

@sonarqubecloud

Copy link
Copy Markdown

@nickboldt nickboldt added Technical review done ⛅ Any procedure has been succesfully tested Ready to merge 💂 lgtm AEM ready to merge PR content is ready to be migrated to AEM labels Oct 22, 2026
@nickboldt
nickboldt merged commit b7291a5 into redhat-developer:release-2.1 Oct 22, 2026
9 checks passed
@openshift-cherrypick-robot

Copy link
Copy Markdown
Contributor

@Zaperex: #2685 failed to apply on top of branch "main":

Applying: chore: update backstage version to 1.54.9
Applying: chore: update rhdh-supported-plugins.sh to fetch from both community and supported catalog index for plugin tables
Using index info to reconstruct a base tree...
M	.github/workflows/generate-supported-plugins-pr.yml
M	modules/extend_dynamic-plugins-reference/rhdh-supported-plugins.sh
Falling back to patching base and 3-way merge...
Auto-merging .github/workflows/generate-supported-plugins-pr.yml
CONFLICT (content): Merge conflict in .github/workflows/generate-supported-plugins-pr.yml
Auto-merging modules/extend_dynamic-plugins-reference/rhdh-supported-plugins.sh
CONFLICT (content): Merge conflict in modules/extend_dynamic-plugins-reference/rhdh-supported-plugins.sh
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0002 chore: update rhdh-supported-plugins.sh to fetch from both community and supported catalog index for plugin tables

Details

In response to this:

/cherrypick main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

nickboldt added a commit that referenced this pull request Oct 22, 2026
…nd supported catalog index [main] (#2688)

* chore: update rhdh-supported-plugins.sh to pull from both community and supported catalog index (#2685)

* chore: update backstage version to 1.54.9

Signed-off-by: Frank Kong <frkong@redhat.com>

* chore: update rhdh-supported-plugins.sh to fetch from both community and supported catalog index for plugin tables

Assisted-By: Codex
Signed-off-by: Frank Kong <frkong@redhat.com>

* chore: address sonarqube warning

Signed-off-by: Frank Kong <frkong@redhat.com>

* Apply batched suggestions from code review

Co-authored-by: Nick Boldt <nboldt@redhat.com>

---------

Co-authored-by: Nick Boldt <nboldt@redhat.com>
(cherry picked from commit b7291a5)

rh-pre-commit.version: 2.4.0
rh-pre-commit.check-secrets: ENABLED

* Apply batched suggestions from code review

Co-authored-by: Nick Boldt <nboldt@redhat.com>

* chore: set target branch branch to 2.*

Signed-off-by: Frank Kong <frkong@redhat.com>

rh-pre-commit.version: 2.4.0
rh-pre-commit.check-secrets: ENABLED

---------

Co-authored-by: Nick Boldt <nboldt@redhat.com>

This branch was successfully deployed

1 active deployment
internal — 601aeaac Deployed Oct 22, 2026 by nickboldt via authorize #300
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AEM ready to merge PR content is ready to be migrated to AEM lgtm Ready to merge 💂 Technical review done ⛅ Any procedure has been succesfully tested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants