Repository navigation
RHDHBUGS-2883: fix: missing plugins from community table due to substring filter [release-1.9] - #2514
Merged
nickboldt merged 1 commit intoJul 30, 2026
Conversation
|
Collaborator
Shellcheck Analysis ResultsChanged shell scripts in this PR: 2 Scripts analyzed:
Check the Files changed tab for detailed shellcheck suggestions. All findings are reported as warnings and won't block the PR. Automated shellcheck analysis • See shellcheck.net for details |
Collaborator
PR Build ResultsBuild failed -- 34/34 titles | 77s Link Validation (lychee)Total: 1438 | OK: 1335 | Errors: 1 | Excluded: 67 | Timeouts: 0
Content Quality AssessmentCQA Report
SummaryChecks: 19 total, 19 pass, 0 fail 19 checks: 19 pass, 0 fail Run Updated 2026-07-30 15:15:01 UTC |
kim-tsao
approved these changes
Jul 30, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The grep -qF used to deduplicate plugins in generate_community_table() does substring matching, which causes plugins to be silently dropped when their name is a prefix of an already-processed plugin. For example, backstage-community-plugin-quay is skipped because backstage-community-plugin-quay-backend is already in the processed list and contains it as a substring. The same issue affects pagerduty-backstage-plugin (matched by pagerduty-backstage-plugin-backend).
Under LC_ALL=C, glob expansion sorts - before ., so the longer -backend variant is always processed first, making the false positive consistent and silent.
Fix: change grep -qF to grep -qxF so the dedup check requires an exact full-line match.
IMPORTANT: Do Not Merge - To be merged by Docs Team Only
Version(s):
Issue:
Preview: